Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes build_bootloader_img.py. #755

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Fixes build_bootloader_img.py. #755

merged 2 commits into from
Dec 31, 2023

Conversation

balazsracz
Copy link
Collaborator

@balazsracz balazsracz commented Dec 20, 2023 •
edited
Loading

This was probably broken since python3.

Binary and string objects do not compare as equal it seems.

@balazsracz
Fixes build_bootloader_img.py.
2fd8ecf 
This was probably broken since python3.
@balazsracz balazsracz requested a review from bakerstu December 20, 2023 13:36
@balazsracz balazsracz merged commit 6e2971d into master Dec 31, 2023
4 checks passed
@balazsracz balazsracz deleted the bracz-bootloader-img-build-fix branch December 31, 2023 11:29
balazsracz added a commit that referenced this pull request Jan 1, 2024
@balazsracz
Merge branch 'master' into bracz-direct-hub-router
9864e0b 
# Via GitHub
* master:
  Adds configuration options for TCP sockets, tuning for Hub app. (#759)
  Limits end to end buffering in gridconnect bridge. (#758)
  Ensures that an executor thread can not be created twice. (#757)
  Fixes build_bootloader_img.py. (#755)

# Conflicts:
#	src/utils/sources
balazsracz added a commit that referenced this pull request Jan 2, 2024
@balazsracz
Merge branch 'master' into bracz-optimize-tcp-socket
781184c 
* master:
  Adds configuration options for TCP sockets, tuning for Hub app. (#759)
  Limits end to end buffering in gridconnect bridge. (#758)
  Ensures that an executor thread can not be created twice. (#757)
  Fixes build_bootloader_img.py. (#755)
balazsracz added a commit that referenced this pull request Jan 2, 2024
@balazsracz
Merge branch 'bracz-optimize-tcp-socket' into bracz-hub-test-app
e6b99c6 
* bracz-optimize-tcp-socket:
  Adds configuration options for TCP sockets, tuning for Hub app. (#759)
  Limits end to end buffering in gridconnect bridge. (#758)
  Ensures that an executor thread can not be created twice. (#757)
  Fixes build_bootloader_img.py. (#755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakerstu bakerstu Awaiting requested review from bakerstu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@balazsracz