Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a test32 target #820

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds a test32 target #820

wants to merge 2 commits into from

Conversation

balazsracz
Copy link
Collaborator

  • Adds targets/test32 which runs the unit tests under 32-bit compilation under linux.
  • Fixes some problems with 32-bit compilation.
  • Blacklists some tests in the 32-bit target only that I couldn't fix now.
  • Adds a special compilation option that allows runningthe Stm32Gpio.cxxtest with including some header files from the Stm32Cube library (they do compile under linux).

@balazsracz balazsracz requested a review from bakerstu February 3, 2025 21:28
bakerstu
bakerstu approved these changes Feb 5, 2025
View reviewed changes
Copy link
Owner

@bakerstu bakerstu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. We have a number of fragile unit tests. I would like us to make a deliberate effort to clean these up. Some of them are squarely my responsibility, such as Broadcast Time Protocol tests, which should be all moved over to FakeClock.

atanisoft
atanisoft reviewed Feb 5, 2025
View reviewed changes
src/openlcb/If.cxx
/// Ensures that the largest bucket in the main buffer pool is exactly the size
/// of a GenMessage.
const unsigned LARGEST_BUFFERPOOL_BUCKET = sizeof(Buffer<openlcb::GenMessage>);
static constexpr unsigned BUCKET_SIZE = std::min(sizeof(Buffer<openlcb::GenMessage>), 64u + sizeof(BufferBase));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this have documentation on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanisoft atanisoft atanisoft left review comments

@bakerstu bakerstu bakerstu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balazsracz @bakerstu @atanisoft