Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add general constant rate provider #266

Merged
merged 4 commits into from
Feb 6, 2025
Merged

add general constant rate provider #266

merged 4 commits into from
Feb 6, 2025

Conversation

franzns
Copy link
Contributor

@franzns franzns commented Feb 5, 2025

Adding one review for all constant rate providers. Even found a few missing cbBTC ones.

@franzns franzns requested review from mkflow27 and Zen-Maxi February 5, 2025 12:42
Adjust description, add checker tag.
Copy link
Collaborator

@Zen-Maxi Zen-Maxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure the outstanding Avax reviews are added using this same common review file. Would like to also suggest we permit Gyroscope team to merge these on their own as they a light review, non-upgradable contracts.

@franzns
Copy link
Contributor Author

franzns commented Feb 5, 2025

Lets make sure the outstanding Avax reviews are added using this same common review file.

Done 15fb94d also closed the other PR

Copy link
Collaborator

@mkflow27 mkflow27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Comment on lines +6 to +16
- [sonic:0xECDfaa456a01c9804Fc8D11955CF4B54E0eA2Bd7](https://sonicscan.org/address/0xECDfaa456a01c9804Fc8D11955CF4B54E0eA2Bd7)
- [arbitrum:0x3a216B01db971Bf28D171C9dA44Cc8C89867697F](https://arbiscan.io/address/0x3a216B01db971Bf28D171C9dA44Cc8C89867697F#code)
- [arbitrum:0x72F6Da3b4bd0Ab7028F52339Ee3B1f94fffe2dD0](https://arbiscan.io/address/0x72F6Da3b4bd0Ab7028F52339Ee3B1f94fffe2dD0#code)
- [arbitrum:0xdcd8db2a23e21a4b9fa3d984d5a31fb554c70832](https://arbiscan.io/address/0xdcd8db2a23e21a4b9fa3d984d5a31fb554c70832#code)
- [ethereum:0xD43F5a722e8e7355D790adda4642f392Dfb820a1](https://etherscan.io/address/0xD43F5a722e8e7355D790adda4642f392Dfb820a1#code)
- [base:0x5E10C2a55fB6E4C14c50C7f6B82bb28A813a4748](https://basescan.org/address/0x5E10C2a55fB6E4C14c50C7f6B82bb28A813a4748)
- [base:0x3e89cc86307aF44A77EB29d0c4163d515D348313](https://basescan.org/address/0x3e89cc86307aF44A77EB29d0c4163d515D348313)
- [base:0x3fA516CEB5d068b60FDC0c68a3B793Fc43B88f15](https://basescan.org/address/0x3fA516CEB5d068b60FDC0c68a3B793Fc43B88f15)
- [base:0x3fA516CEB5d068b60FDC0c68a3B793Fc43B88f15](https://basescan.org/address/0x3fA516CEB5d068b60FDC0c68a3B793Fc43B88f15)
- [base:0xd58338f102e8de2e3d9d54cc043c6d606826a790](https://basescan.org/address/0xd58338f102e8de2e3d9d54cc043c6d606826a790)
- [base:0x4a0f0012004bc22d4fdb818b9c539e78adc0c69d](https://basescan.org/address/0x4a0f0012004bc22d4fdb818b9c539e78adc0c69d)
- [avalanche:0xd0C13867BeA969398370B2A2B9124e3b2E48743C](https://snowtrace.io/address/0xd0C13867BeA969398370B2A2B9124e3b2E48743C/contract/43114/code)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to have them in one file

@mkflow27 mkflow27 merged commit 996a235 into main Feb 6, 2025
1 check passed
@mkflow27 mkflow27 deleted the constant-rp branch February 6, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants