Add EqualsAny node #262
Merged
Add EqualsAny node #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviojacobi
commented
Jan 20, 2025
otaviojacobi
force-pushed
the
compile-any-node-as-operand
branch
3 times, most recently
from
a4c9bcb to
77c25f0
Compare
otaviojacobi
changed the title
Page-
reviewed
Jan 20, 2025
| @@ -1000,6 +1002,10 @@ const typeRules: Dictionary<MatchFn> = { | |||
| return `COALESCE(JSON_AGG(${field}), '[]')`; | |||
| }, | |||
| Equals: Comparison('Equals'), | |||
| EqualsAny: (args, indent) => { | |||
| checkArgs('EqualsAny', args, 2); | |||
| return `${AnyValue(getAbstractSqlQuery(args, 0), indent)} = ANY(${AnyValue(getAbstractSqlQuery(args, 1), indent)})`; | |||
There was a problem hiding this comment.
Ideally it'd be possible to do
Suggested change
| return `${AnyValue(getAbstractSqlQuery(args, 0), indent)} = ANY(${AnyValue(getAbstractSqlQuery(args, 1), indent)})`; | |
| return `${AnyValue(getAbstractSqlQuery(args, 0), indent)} = ${typeRules.Any(getAbstractSqlQuery(args, 1), indent)}`; |
to reuse the same Any node for the relevant part, although I'm fine with it as-is and leave that as a potential future thing
There was a problem hiding this comment.
@Page- They are currently fairly similar, the only reason why can't currently be done this way is because Any requires a innerType to be casted, which I am not sure we want to infer for in. Ofc I can rework the Any logic to be able to handle no parameter on the innerTyping but at this point we could just use the AnyNode anyway. I think if we decide to do it, it should be part of a follow up PR
There was a problem hiding this comment.
Yeah, I just wanted to raise awareness to consider that for future
Change-type: minor
otaviojacobi
force-pushed
the
compile-any-node-as-operand
branch
from
77c25f0 to
79d5bce
Compare
Page-
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: minor