Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI error of tar files created on mac #53

Closed
wants to merge 2 commits into from
Closed

Fix CI error of tar files created on mac #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b850e25
Fix CI error of tar files created on mac
otaviojacobi Jul 12, 2024
e8b2e36
Stop actively supporting v1 docker image format
otaviojacobi Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified test/build/test-files/archives/failure-layers.tar
View file
Open in desktop
Binary file not shown.
Binary file modified test/build/test-files/archives/failure.tar
View file
Open in desktop
Binary file not shown.
Binary file modified test/build/test-files/archives/success.tar
View file
Open in desktop
Binary file not shown.
24 changes: 8 additions & 16 deletions test/multibuild/build.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,14 +320,10 @@ describe('Resolved project building', () => {
const newTask = resolveTask(task, 'amd64', 'intel-nuc', resolveListeners);

resolve(runBuildTask(newTask, docker, secretMap, buildVars));
})
.then((image) => {
expect(image).to.have.property('successful').that.equals(true);
return checkExists(image.name!);
})
.then((inspect: any) => {
expect(inspect).to.have.property('Architecture').that.equals('amd64');
});
}).then((image) => {
expect(image).to.have.property('successful').that.equals(false);
expect(image).to.have.property('error').that.is.not.null;
});
});

it('should build without "platform" flag (v1 manifest) for multi-stage builds', async () => {
Expand All @@ -349,14 +345,10 @@ describe('Resolved project building', () => {
const newTask = resolveTask(task, 'amd64', 'intel-nuc', resolveListeners);

resolve(runBuildTask(newTask, docker, secretMap, buildVars));
})
.then((image) => {
expect(image).to.have.property('successful').that.equals(true);
return checkExists(image.name!);
})
.then((inspect: any) => {
expect(inspect).to.have.property('Architecture').that.equals('amd64');
});
}).then((image) => {
expect(image).to.have.property('successful').that.equals(false);
expect(image).to.have.property('error').that.is.not.null;
});
});

it('should build using "platform" flag (v2 manifest) on third party registry', async () => {
Expand Down