ci: check version consistency between autotools and cmake #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keLists.txt are consistent to each other
muxator
force-pushed
the
check-versions-consistency
branch
4 times, most recently
from
abf1fb8 to
d50f346
Compare
muxator
force-pushed
the
check-versions-consistency
branch
from
d50f346 to
3533aa8
Compare
matteonardelli
added a commit
that referenced
this pull request
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our project version number is structured as following:
major.minor.patch-itcoin-frost-build(for example:0.3.0-frost-1).secp256k1 v0.3.0 introduced support for building via CMake. In the process, it also duplicated the places where the version information is stored: no longer just
configure.ac, but alsoCMakeLists.txt.We now have to ensure that the two files are in sync. Additionally, we have to do the same check for the frost-specific version number.
The PR introduces a script that takes care of this and integrates the check in the CI.