feat(cadence): Preliminary PostgreSQL support #1172
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the chart to better support a PostgreSQL backend. This commit does not provide feature parity with existing Cassandra or MySQL support. The chart has options to spin up a MySQL or Cassandra instance and configure it for you. This commit offers nothing equivalent for Postgres; if you want to use a Postgres backend you must provision and configure it yourself. More specifically, we assume that: - The Postgres service is up and running. - The `cadence` user and its password are configured. - The databases `cadence` and `cadence_visibility` exist and are accessible by the `cadence` user. (This assumes default names are used. Adjust accordingly if you're using different names.) As long as those requirements are met, the jobs for "schema setup" and "schema update" should work just as they would for the MySQL backend. The option to disable either job through the "schema.setup.enabled" and "schema.update.enabled" values remains as before. The changes to support this new behavior are very minor. We simply remove an overly strict "if mysql" check in the setup job and add an postgres implementation for the update job.
|
I admit that this change is lightly tested and my knowledge of helm is not great. I present this PR without strong confidence that it is as solid as it could be. But I'm pretty sure it is an improvement on the current chart, so I wanted to at least make it available for inclusion in upstream, if desired. |
|
Thanks @richardlarocque ! I'll review it as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the chart to better support a PostgreSQL backend.
This commit does not provide feature parity with existing Cassandra or
MySQL support. The chart has options to spin up a MySQL or Cassandra
instance and configure it for you. This commit offers nothing
equivalent for Postgres; if you want to use a Postgres backend you must
provision and configure it yourself.
More specifically, we assume that:
cadenceuser and its password are configured.cadenceandcadence_visibilityexist and areaccessible by the
cadenceuser.(This assumes default names are used. Adjust accordingly if you're
using different names.)
As long as those requirements are met, the jobs for "schema setup" and
"schema update" should work just as they would for the MySQL backend.
The option to disable either job through the "schema.setup.enabled"
and "schema.update.enabled" values remains as before.
The changes to support this new behavior are very minor. We simply
remove an overly strict "if mysql" check in the setup job and add an
postgres implementation for the update job.
Checklist