Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge #1

Merged
merged 822 commits into from
Jul 20, 2022
Merged

Merge #1

merged 822 commits into from
Jul 20, 2022

Conversation

barry-jin
Copy link
Owner

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

rohitgr7 and others added 30 commits May 19, 2022 13:25
@rohitgr7 @carmocca
Add deprecation path for the old Callback module (#13031)
eb21135
@akihironitta
GPU CI: Increase timeout from 65 to 100min (#13104)
874ae50
@mads-oestergaard @akihironitta @carmocca
Update trainer profiler typehint to use Profiler instead of the dep…
11e289a 
…recated `BaseProfiler` (#13084)

* Fix trainer profiler typehint

* Remove unused import of deprecated BaseProfiler

* Update CHANGELOG.md

Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@awaelchli
Avoid firewall message from find_free_network_port (#13113)
880224d
@justusschock
Rename min_gpus to min_cuda_gpus (#13133)
fbd887d 
* rename min_gpus to min_cuda_gpus
@akihironitta
Use coverage>=6.4 (#13132)
2dc14e7
@edward-io @pre-commit-ci
@Borda @akihironitta @justusschock
Add accelerator method teardown() (#11935)
45f57fd 
* refactor strategies to use accelerator

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Aki Nitta <[email protected]>

* Apply suggestions from code review

Co-authored-by: Aki Nitta <[email protected]>

* update changelog

* remove changes to strategies

* update changelog

* update device-specific teardowns

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* partially revert

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update strategy.py

* swap hpu

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add missing log

* unused import

* order matters for tpu?

Co-authored-by: edward-io <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Aki Nitta <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
@jiny419
Fix import statement in tutorial (#13130)
29fe1da 
fix tutorial

Co-authored-by: Jiny491 <[email protected]>
@carmocca
Fix torchelastic detection with non-distributed installations (#13142)
c5938f8 
* Fix torchelastic detection under Mac

* CHANGELOG
@shenoynikhil @carmocca
Removed flush_logs_every_n_steps argument from Trainer (#13074)
dd47518 
Co-authored-by: Carlos Mocholí <[email protected]>
@dependabot @Borda
Update mlflow requirement from <=1.24.0,>=1.0.0 to >=1.0.0,<1.27.0 in…
a3c0a47 
… /requirements (#13127)

* Update mlflow requirement in /requirements

Updates the requirements on [mlflow](https://github.com/mlflow/mlflow) to permit the latest version.
- [Release notes](https://github.com/mlflow/mlflow/releases)
- [Changelog](https://github.com/mlflow/mlflow/blob/master/CHANGELOG.md)
- [Commits](mlflow/mlflow@1.0.0...v1.26.0)

---
updated-dependencies:
- dependency-name: mlflow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jirka <[email protected]>
@dependabot
Update neptune-client requirement from <=0.15.2,>=0.10.0 to >=0.10.0,…
0447720 
…<0.16.3 in /requirements (#13056)

* Update neptune-client requirement in /requirements

Updates the requirements on [neptune-client](https://github.com/neptune-ai/neptune-client) to permit the latest version.
- [Release notes](https://github.com/neptune-ai/neptune-client/releases)
- [Changelog](https://github.com/neptune-ai/neptune-client/blob/master/CHANGELOG.md)
- [Commits](neptune-ai/neptune-client@0.10.0...0.16.2)

---
updated-dependencies:
- dependency-name: neptune-client
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Update matplotlib requirement from <=3.5.1,>3.1 to >3.1,<3.5.3 in /re…
7172c21 
…quirements (#13053)

* Update matplotlib requirement in /requirements

Updates the requirements on [matplotlib](https://github.com/matplotlib/matplotlib) to permit the latest version.
- [Release notes](https://github.com/matplotlib/matplotlib/releases)
- [Commits](matplotlib/matplotlib@v3.1.1...v3.5.2)

---
updated-dependencies:
- dependency-name: matplotlib
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Update jsonargparse[signatures] requirement from <=4.7.1,>=4.7.1 to >…
5cf0e37 
…=4.7.1,<4.7.4 in /requirements (#13052)

* Update jsonargparse[signatures] requirement in /requirements

Updates the requirements on [jsonargparse[signatures]](https://github.com/omni-us/jsonargparse) to permit the latest version.
- [Release notes](https://github.com/omni-us/jsonargparse/releases)
- [Changelog](https://github.com/omni-us/jsonargparse/blob/master/CHANGELOG.rst)
- [Commits](omni-us/jsonargparse@v4.7.1...v4.7.3)

---
updated-dependencies:
- dependency-name: jsonargparse[signatures]
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Update tensorboard requirement from <=2.8.0,>=2.2.0 to >=2.2.0,<2.10.…
d9c97cd 
…0 in /requirements (#13049)

* Update tensorboard requirement in /requirements

Updates the requirements on [tensorboard](https://github.com/tensorflow/tensorboard) to permit the latest version.
- [Release notes](https://github.com/tensorflow/tensorboard/releases)
- [Changelog](https://github.com/tensorflow/tensorboard/blob/master/RELEASE.md)
- [Commits](tensorflow/tensorboard@2.2.0...2.9.0)

---
updated-dependencies:
- dependency-name: tensorboard
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Update deepspeed requirement from <0.6.0 to <0.7.0 in /requirements (#…
e19babc 
…13048)

* Update deepspeed requirement from <0.6.0 to <0.7.0 in /requirements

Updates the requirements on [deepspeed](https://github.com/microsoft/DeepSpeed) to permit the latest version.
- [Release notes](https://github.com/microsoft/DeepSpeed/releases)
- [Commits](deepspeedai/DeepSpeed@v0.1.0...v0.6.4)

---
updated-dependencies:
- dependency-name: deepspeed
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Update typing-extensions requirement from <=4.1.1,>=4.0.0 to >=4.0.0,…
9ac5cca 
…<4.2.1 in /requirements (#13054)

* Update typing-extensions requirement in /requirements

Updates the requirements on [typing-extensions](https://github.com/python/typing) to permit the latest version.
- [Release notes](https://github.com/python/typing/releases)
- [Changelog](https://github.com/python/typing/blob/master/typing_extensions/CHANGELOG.md)
- [Commits](python/typing@4.0.0...4.2.0)

---
updated-dependencies:
- dependency-name: typing-extensions
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@akihironitta @rohitgr7
Document CI/CD (#12980)
a6e9bc2 
* Add README.md to .github/workflows/

* Link CI/CD doc page from contributing.md

Co-authored-by: Rohit Gupta <[email protected]>
@akihironitta @carmocca
Pin protobuf version (#13177)
40dddc8
@carmocca
xfail flaky quantization test blocking CI (#13177)
50326e9
@carmocca
Fix standalone test collection (#13177)
9945d02
@carmocca
Revert "Update deepspeed requirement from <0.6.0 to <0.7.0 in /requir…
3780407 
…ements (#13048)" (#13177)

This reverts commit e19babc.
@carmocca
Avoid changing the current cudnn.benchmark value (#13154)
01ebb1f
@ar90n @carmocca
Fix not running test codes (#13089)
90acf90 
Co-authored-by: Carlos Mocholí <[email protected]>
@Borda
add @akihironitta among CI/CD owners (#13139)
b2eb2b7 
add @akihironitta
@rohitgr7 @justusschock @carmocca
Fix logging's step values when multiple dataloaders are used during e…
ba43882 
…valuation (#12184)

Co-authored-by: Justus Schock <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@carmocca
[CLI] Respect existing seed by default (#13110)
5bdb936
@shenoynikhil @rohitgr7
@akihironitta @carmocca
Removed weights_summary argument from Trainer (#13070)
f4f14bb 
Co-authored-by: rohitgr7 <[email protected]>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Carlos Mocholí <[email protected]>
@akihironitta @carmocca
Specify Trainer(benchmark=False) in parity benchmarks (#13182)
a21e6c3 
Co-authored-by: Carlos Mocholí <[email protected]>
@ekagra-ranjan @carmocca
Fix instruction for cherry pick way of fixing mixed branches (#13186)
011684a 
Co-authored-by: Carlos Mocholí <[email protected]>
tchaton and others added 29 commits July 15, 2022 19:12
@tchaton
Add --app_args support from the CLI (#13625)
2a873da
@Borda
bump base NGC image (#13346)
954fd7e
@Borda @pre-commit-ci
CI: debug TPU failing tests (#13679)
e23756b 
* list pytest

* docs

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* list

* test

* fix GK

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@krishnakalyan3 @carmocca
Fix mypy errors attributed to `pytorch_lightning.utilities.distribute…
2845e75 
…d` (#13678)


Co-authored-by: Carlos Mocholí <[email protected]>
@s-rog
Move s-rog (myself) from core to alumni (#13694)
e196e19 
Update governance.rst
@manskx @pre-commit-ci
@akihironitta @Borda
Add CI app cloud e2e & fix setup UI download (#13499)
b822ac1 
* Add CI app e2e
* update UserID
* fix apps cleanup
* download frontend inside setup.py

Co-authored-by: mansy <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Akihiro Nitta <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
@dependabot
Bump pypa/gh-action-pypi-publish from 1.4.1 to 1.5.0 (#13621)
258b58e 
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.4.1 to 1.5.0.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@v1.4.1...v1.5.0)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@JeroenDelcour
Update docs README on how to build docs (#13465)
d18f45b 
update docs README on how to build docs

Co-authored-by: Jeroen Delcour <[email protected]>
@georgestein @rohitgr7
Fix trainer.predict(return_predictions=False) does not track `batch…
0449e86 
…_indices` (#13629)

* Pull request for fixing issue #13580
* chlog and test
* disable track for epoch

Co-authored-by: rohitgr7 <[email protected]>
@carmocca
Run standalone tests in batches (#13673)
d058190
@tchaton
Change AWS credentials to Lightning ones (#13703)
d4c7f91
@Borda
add codeownser for docs - @Felonious-Spellfire (#13717)
23105b4
@Borda @rohitgr7
define app 0.6 (#13699)
35ec79a 
* define app 0.6

* req

* fix link

* txt

* ex

* gk

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <[email protected]>

* Apply suggestions from code review

* lapp 0.5.2

Co-authored-by: Rohit Gupta <[email protected]>
@carmocca
Allow CUDA and IPU tests without the CI environment var (#13676)
0e5a51f
@Borda
CI: revert skip jobs (#13715)
1d59b3f 
revert skip jobs
@akihironitta @Borda
CI: Fix false negatives by the labeler (#13722)
904c2fe 
* Add change to src/lightning_app/**/*

* Update filter

* Update config

* Revert "Add change to src/lightning_app/**/*"

This reverts commit e411de1.

* Examples

Co-authored-by: Jirka Borovec <[email protected]>
@rohitgr7 @akihironitta
Remove conda installation guide from lightning docs (#13727)
7b0563d 
Co-authored-by: Akihiro Nitta <[email protected]>
@justusschock @lexierule
Rename GPUAccelerator to CUDAAccelerator
c75457d
@justusschock @lexierule
Add back GPUAccelerator and deprecate it
abf82b3
@Borda
CI: fix ignored paths (#13733)
6cbd9d7
@rohitgr7 @akihironitta
Use global_step while restoring logging step for old checkpoints (#…
c67b075 
…13645)

Co-authored-by: Akihiro Nitta <[email protected]>
@Borda @raoakarsha @pre-commit-ci
CI: debug HPU flow (#13419)
64e8e8e 
* Update the hpu-tests.yml to pull docker from vault
* fire & sudo
* habana-gaudi-hpus
* Check the driver status on gaudi server (#13718)

Co-authored-by: arao <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Akarsha Rao <[email protected]>
@dependabot
Update typing-extensions requirement from <4.2.1,>=4.0.0 to >=4.0.0,<…
df80289 
…4.3.1 in /requirements (#13529)

Update typing-extensions requirement in /requirements

Updates the requirements on [typing-extensions](https://github.com/python/typing_extensions) to permit the latest version.
- [Release notes](https://github.com/python/typing_extensions/releases)
- [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md)
- [Commits](python/typing_extensions@4.0.0...4.3.0)

---
updated-dependencies:
- dependency-name: typing-extensions
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] pre-commit suggestions (#13540)
c028ff3 
updates:
- [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
[FIX] Native FSDP precision + tests (#12985)
d786985
@carmocca
Simplify fetching's loader types (#13111)
bbd364a
@manskx @awaelchli
Include app templates to the lightning and app packages (#13731)
ca1917e 
* Include app templates to the package

Co-authored-by: mansy <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
@Jungwon-Lee @carmocca
Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoin…
b40766c 
…t.py (#13617)

Co-authored-by: Carlos Mocholí <[email protected]>
@NathanielDamours @carmocca @awaelchli
Fix typos initialize in docs (#13557)
cd20699 
Co-authored-by: Carlos Mocholí <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
@barry-jin barry-jin merged commit 5d023d0 into barry-jin:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.