[TaT] Pre-requisites for flexible builds. #1352
Merged
+485
−387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marius-baseten
changed the title
marius-baseten
requested review from
tyranitar,
nnarayen and
squidarth
and removed request for
tyranitar
marius-baseten
force-pushed
the
marius/flex-build
branch
3 times, most recently
from
b6d026b to
f541b1e
Compare
tyranitar
approved these changes
Jan 30, 2025
squidarth
approved these changes
Feb 4, 2025
|
|
||
| @click.command() | ||
| @click.option("--truss_type", required=True) | ||
| def docker_build_setup(truss_type: str) -> None: |
There was a problem hiding this comment.
would be good to leave some comments here about the context in which this should be run (on a builder)
marius-baseten
force-pushed
the
marius/flex-build
branch
from
f541b1e to
50f023e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
truss==fromclient_versiontransmitted to backed, because it's not a PEP 440 compliant version. Plus it's not centrally managed in the truss code base...truss/contexts/docker_build_setup.py- this is functionally equivalend to https://github.com/basetenlabs/baseten/blob/master/backend/deployment/tekton/build_tekton_configs/old_build_setup.sh.jinja💻 How
🔬 Testing