Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when using secrets without --trusted #719

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Warn when using secrets without --trusted #719

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95a9ca6
warn when using secrets without trusted
helenlyang Nov 7, 2023
20f3496
Merge branch 'main' into helenyang/bt-8704-add-warning-when-using-sec…
helenlyang Nov 7, 2023
db2bfc2
sid CR: move below success text + set style to yellow
helenlyang Nov 7, 2023
bb9bdb4
sid CR: move text, change color, add todo
helenlyang Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions truss/cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,14 @@ def push(

click.echo(draft_model_text)

# Log a warning if using secrets without --trusted.
# TODO(helen): this could be moved to a separate function that includes more config checks.
if tr.spec.config.secrets and not trusted:
not_trusted_text = """Warning: your Truss has secrets but was not pushed with --trusted.
Please push with --trusted to grant access to secrets.
"""
console.print(not_trusted_text, style="red")

logs_url = remote_provider.get_remote_logs_url(service) # type: ignore[attr-defined]
rich.print(f"🪵 View logs for your deployment at {logs_url}")

Expand Down
Loading