Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add has_parallel_download feature to detect if rctx.download supports parallel downloads #29

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

mortenmj
Copy link
Contributor

@mortenmj mortenmj commented Dec 17, 2023

Coming in 7.1.0, repository_ctx#download has a new argument, block:

If set to false, the call returns immediately and instead of the regular return value, it returns a token with one single method, wait(), which blocks until the download is finished and returns the usual return value or throws as usual.

It would be useful to be able to update repository rules to use this feature when available.

features.bzl Outdated Show resolved Hide resolved
@mortenmj mortenmj requested a review from fmeum December 17, 2023 15:18
features.bzl Outdated Show resolved Hide resolved
@mortenmj mortenmj requested a review from fmeum December 17, 2023 16:08
@fmeum fmeum enabled auto-merge (squash) December 17, 2023 16:40
@fmeum fmeum merged commit 52bf4a1 into bazel-contrib:main Dec 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants