Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Updated pip and packaging versions to work with free-threading packages (#2514) #2584

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Jan 26, 2025

This reverts commit fbf8bc1 (#2514)

Also, update the CHANGELOG about the reverting.

Fixes #908, which is about the pip-compile not using the right files
for performing the locking. It seems that the pip upgrade regressed
this error.

…g packages (bazelbuild#2514)

This reverts commit fbf8bc1.

Also, update the CHANGELOG about the reverting.

Fixes bazelbuild#908.
Copy link
Collaborator

@rickeylev rickeylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update description to mention the problem and why this fixes it. Otherwise LGTM

@aignas aignas enabled auto-merge January 28, 2025 02:51
@aignas aignas added this pull request to the merge queue Jan 28, 2025
Merged via the queue into bazelbuild:main with commit 309ee59 Jan 28, 2025
4 checks passed
@aignas aignas deleted the revert-2514 branch January 28, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile_pip_requirements no longer uses predictable paths
2 participants