Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSPA-3196 Update dependencies for later python versions #65

Closed
wants to merge 1 commit into from

Conversation

bharjr01
Copy link

@bharjr01 bharjr01 commented Dec 6, 2023

No description provided.

@bharjr01 bharjr01 added the bamboo label Dec 6, 2023
Copy link
Collaborator

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to install twisted with pip install twisted to make this work - otherwise make test failed. Does this need to be added to requirements.txt? Also, should we be doing a pip freeze here too? Update: it looks like this was removed from setup.py at some stage, but is weirdly not showing in the Files Changed.

I also would expect the README to be updated to say which version of python is needed.

@nigelmegitt
Copy link
Collaborator

Looking at the build issues I'm having, and the error messages, I think we need to consider updating to something like poetry too - see #64 for an example of work already done for this. I'm just not sure if we must do that as part of MSPA-3196, but we certainly should do it soon.

@bharjr01
Copy link
Author

Closing as the commit is used in #68

@bharjr01 bharjr01 closed this Dec 22, 2023
@bharjr01 bharjr01 deleted the MSPA-3196-update-deps branch December 22, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants