Implement the IMSC HRM for EBU-TT-D documents #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes all the imsc-hrm-tests test files that can be valid EBU-TT-D, fixed up to be so.
Iterate through the characters getting the glyphs. Decide if they need to be rendered or copied from the cache. Compute NRGA, and check the Glyph Cache size on each iteration. Still to do: compute copyDur and renderDur. Needs UAX24 implementation too.
Parses the Unicode UAX24 scripts list and generates a python file that specifies those lists in a way that can be queried later. Needed for the IMSC-HRM implementation.
* Fix NRGA calculation to square the area * Calculate _GCpy and _Ren based on uax24 script Passes all but 2 of the tests. TODO: tidy up stdout and log messages
For example, as might occur if text is broken with a `<br/>` child element of the `<span>`
Change all the `print()`s to `log.debug()`s so the log is readable. Fix a bug where a `<br/>` after some text content would cause the previous text to be processed and counted again, which caused dur014-pass to fail incorrectly.
Should have 0.5s available render time for second ISD.
And regenerate uax24.py script
Previously, we processed each separate `p` in an ISD distinctly as a separate ISD, which was wrong. Now, gather all the elements in each ISD together and process as a group. Also tidies up the time handling. When an ISD has a region with an opaque background colour and showBackground="always", there can _never_ be an empty ISD, because the background always needs to be painted.
The log handling in --verbose mode is flaky, not sure why.
Makes the tests behave as expected.
The upstream repo has had those conversions applied, so the tests are now the same.
nigelmegitt
force-pushed
the
imsc-hrm
branch
from
2704d51 to
8e835ad
Compare
Came back during rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides improved support for creating EBU-TT-D documents from XML sources, and implements validation of those documents against the IMSC HRM at https://www.w3.org/TR/imsc-hrm/ - it incorporates the tests at w3c/imsc-hrm-tests that are valid EBU-TT-D and runs those tests.
Also closes #62 by incorporating the changes proposed in #63.