Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introducing the role mixin feature #70

Merged
merged 11 commits into from
May 1, 2024
Merged

feat: introducing the role mixin feature #70

merged 11 commits into from
May 1, 2024

Conversation

AhmericUiCentric
Copy link

No description provided.

nigelmegitt
nigelmegitt reviewed Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully helpful comments for tomorrow!

ebu_tt_live/bindings/__init__.py Outdated Show resolved Hide resolved
ebu_tt_live/bindings/__init__.py Show resolved Hide resolved
ebu_tt_live/bindings/__init__.py Outdated Show resolved Hide resolved
ebu_tt_live/bindings/__init__.py Outdated Show resolved Hide resolved
ebu_tt_live/bindings/__init__.py Outdated Show resolved Hide resolved
ebu_tt_live/bindings/__init__.py Outdated Show resolved Hide resolved
ebu_tt_live/xsd/ebutt_metadata.xsd Outdated Show resolved Hide resolved
nigelmegitt
nigelmegitt reviewed Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great stuff, and can certainly go to review. My non-developer review comments (which are quite developer-ish!) here.

ebu_tt_live/bindings/__init__.py Outdated Show resolved Hide resolved
ebu_tt_live/bindings/test/test_role_mixin.py Show resolved Hide resolved
ebu_tt_live/bindings/test/test_role_mixin.py Outdated Show resolved Hide resolved
testing/bdd/test_role.py Outdated Show resolved Hide resolved
testing/bdd/test_role.py Outdated Show resolved Hide resolved
williamjhughes
williamjhughes approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@williamjhughes williamjhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me!

@AhmericUiCentric AhmericUiCentric merged commit 0b6f1cc into master May 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nigelmegitt nigelmegitt nigelmegitt left review comments

@williamjhughes williamjhughes williamjhughes approved these changes

Assignees
No one assigned
Labels
bamboo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AhmericUiCentric @nigelmegitt @williamjhughes @ahmeric