Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warnings for react 16.9.x #27

Closed
wants to merge 1 commit into from

Conversation

JasonBristol
Copy link
Contributor

@JasonBristol JasonBristol commented Sep 1, 2019

Included in this PR

@bberak
Copy link
Owner

bberak commented Sep 2, 2019

Nice one @JasonBristol.

Question, if we renamed the lifecycle methods to UNSAFE_* - will this have any negative impacts on backwards functionality? If someone is running an old version of React - will this break their game?

I'll have to do a bit of research on how to deal with this - I'm sure we're not the only ones facing this problem.

@JasonBristol
Copy link
Contributor Author

JasonBristol commented Sep 2, 2019

@bberak I was under the impression that it wouldn't, but after some more research it looks like these aliases only exist in react 16.9+. For now it might actually be safer if we just keep the old names for backwards compatibility.

I'll close this PR and move the discussion to #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants