Grad2-2604 message changes for 2018 program non graduates. #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cditcher
requested changes
Apr 26, 2024
| @@ -0,0 +1,2 @@ | |||
| UPDATE TRANSCRIPT_MESSAGE SET GRAD_PROJECTED_MESSAGE='Based on the information provided by the school, this student cannot satisfy the requirements for the Graduation Program %s. Note: Students are no longer eligible to graduate on the 2018 graduation program unless required courses were completed by June 30, 2024. Contact your school counselor for more information.' WHERE GRADUATION_PROGRAM_CODE = '2018-EN' AND MESSAGE_TYPE_CODE = 'NOT_GRADUATED'; | |||
There was a problem hiding this comment.
Hi @githubmamatha I think the ticket asks for both the MAIN AND PROJECTED messages to be changed for 2018-EN and also 2018-PF. Your flyway only updates PROJECTED for 2018-EN and MAIN for 2018-PF. You could probably update your WHERE clauses to say WHERE GRADUATION_PROGRAM_CODE IN('2018-EN', '2018-PF) AND MESSAGE_TYPE_CODE = 'NOT_GRADUATED'
Also, I noticed you have applied the changes in DEV schema already. Pls roll back before we do a deployment.
Grad2 2604 msg changes2018 grad prog new PR to old PR
|
|
ZAP scan updates included in the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main message and projected message changes for 2018 grad program not graduated students is done.