Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TH-1099 Improve logging, null checks, and XML template update #686

Merged
merged 2 commits into from
Dec 12, 2024
Merged

TH-1099 Improve logging, null checks, and XML template update #686

merged 2 commits into from
Dec 12, 2024

Conversation

ionwyn
Copy link
Collaborator

@ionwyn ionwyn commented Dec 12, 2024 •
edited
Loading

The changes in this PR:

  • Improve error messages by showing the exception thrown (if any) to end user. This includes exceptions thrown by geoservers or internal server errors.
  • Added null checks to eliminate null characters in CSV headers, rows, and XML template isPointonRfiSegment.xml
  • Update the XML template isPointOnRfiSegment.xml by replacing non-resolving xsd schema URL to a correct one defined by OpenGIS, and reformat according to the schema.
  • Linting

@ionwyn ionwyn added the bug Something isn't working label Dec 12, 2024
@ionwyn ionwyn self-assigned this Dec 12, 2024
@bcgov-brwang bcgov-brwang merged commit eaeb2b9 into master Dec 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcgov-brwang bcgov-brwang bcgov-brwang approved these changes

@zgong-gov zgong-gov Awaiting requested review from zgong-gov

Assignees

@ionwyn ionwyn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ionwyn @bcgov-brwang