Pre-review adjustments

bcgov · Jan 10, 2025 · 19be56b · 19be56b
1 parent 69a87f3
commit 19be56b
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 20 deletions.
diff --git a/...n-data-comparison/_tests_/unit/application-data-comparison.compareApplicationData.spec.ts b/...n-data-comparison/_tests_/unit/application-data-comparison.compareApplicationData.spec.ts
@@ -16,7 +16,6 @@ describe("compareApplicationData", () => {
     const result = compareApplicationData(current, current);
 
     // Assert
-    console.log(JSON.stringify(result, null, 2));
     expect(result).toHaveLength(0);
   });
 
@@ -60,70 +59,57 @@ describe("compareApplicationData", () => {
         key: "bcResident",
         newValue: "yes",
         oldValue: "changed yes",
-        index: undefined,
         changeType: "updated",
         changes: [],
       },
       {
         key: "hasDependents",
         newValue: "no",
         oldValue: "changed no",
-        index: undefined,
         changeType: "updated",
         changes: [],
       },
       {
         key: "calculatedTaxYear",
         newValue: 2023,
         oldValue: 2000,
-        index: undefined,
         changeType: "updated",
         changes: [],
       },
       {
         key: "isFullTimeAllowed",
         newValue: "",
-        oldValue: undefined,
-        index: undefined,
         changeType: "updated",
         changes: [],
       },
       {
         key: "studentGivenNames",
         newValue: null,
-        oldValue: undefined,
-        index: undefined,
         changeType: "updated",
         changes: [],
       },
       {
         key: "showParentInformation",
         newValue: null,
         oldValue: true,
-        index: undefined,
         changeType: "updated",
         changes: [],
       },
       {
         key: "applicationPDPPDStatus",
         newValue: "no",
         oldValue: "changed no",
-        index: undefined,
         changeType: "updated",
         changes: [],
       },
       {
         key: "myStudyPeriodIsntListed",
-        newValue: undefined,
-        oldValue: undefined,
-        index: undefined,
         changeType: "updated",
         changes: [
           {
             key: "offeringnotListed",
             newValue: false,
             oldValue: true,
-            index: undefined,
             changeType: "updated",
             changes: [],
           },

diff --git a/...kend/libs/utilities/src/application-data-comparison/application-data-comparison.models.ts b/...kend/libs/utilities/src/application-data-comparison/application-data-comparison.models.ts
@@ -8,7 +8,7 @@ export enum ChangeTypes {
    */
   ItemsRemoved = "itemsRemoved",
   /**
-   * An array had at least one property removed.
+   * An object had at least one property removed.
    */
   PropertiesRemoved = "propertiesRemoved",
 }

diff --git a/...ges/backend/libs/utilities/src/application-data-comparison/application-data-comparison.ts b/...ges/backend/libs/utilities/src/application-data-comparison/application-data-comparison.ts
@@ -133,7 +133,7 @@ function checkObjectChanges(
   parentChange: ApplicationDataChange,
   options?: { propertyKey?: string; index?: number },
 ): void {
-  // Property is a object that should have its properties checked.
+  // Property is an object that should have its properties checked.
   if (!isEqual(currentData, previousData)) {
     const objectPropertyChange = new ApplicationDataChange({
       key: options?.propertyKey,

diff --git a/sources/packages/web/src/assets/css/formio-shared.scss b/sources/packages/web/src/assets/css/formio-shared.scss
@@ -754,15 +754,15 @@ td .formio-custom-tooltip:hover .tooltip-text {
 // Styles related to the application changes
 // between the current and previous application versions.
 .changed-value-base {
-  color: #dc2525;
+  color: $application-changed-value-color;
   border-radius: 5px;
-  border: 1px solid #dc2525;
+  border: 1px solid $application-changed-value-color;
   padding: 4px;
 }
 
 .changed-value-content-base {
   @extend .label-small-bold;
-  background: #dc2525;
+  background: $application-changed-value-color;
   color: white;
   border-radius: 5px;
   display: block;

diff --git a/sources/packages/web/src/assets/css/global-style-variables.scss b/sources/packages/web/src/assets/css/global-style-variables.scss
@@ -27,6 +27,7 @@ $secondary-header-color-lt: #8692a4;
 $app-content-color: #333a47;
 $panel-warning-color: #f3b229;
 $panel-error-color: #dc2525;
+$application-changed-value-color: #dc2525;
 $button-font-color: #ffffff;
 
 /** SCSS Font Size variables **/

diff --git a/sources/packages/web/src/types/contracts/ApplicationDataComparison.ts b/sources/packages/web/src/types/contracts/ApplicationDataComparison.ts
@@ -8,7 +8,7 @@ export enum ChangeTypes {
    */
   ItemsRemoved = "itemsRemoved",
   /**
-   * An array had at least one property removed.
+   * An object had at least one property removed.
    */
   PropertiesRemoved = "propertiesRemoved",
 }