Skip to content

Commit

Permalink
#3866 - Parse the last 2 characters in NEB as decimal places. (#3872)
Browse files Browse the repository at this point in the history
## SFAS Import update on NEB

- [x] NEB: Logic for parsing NEB updated to consider the last 2
characters as decimals.
- [x] BCGG: Verified that the logic for parsing BCGG is not considering
decimals.(No code change here)
- [x] Verified the part time applications in import are **NOT**
considering decimals during the parsing of amounts.
- [x] Verified the full time applications in import are considering last
2 characters as decimals during the parsing of amounts.

## E2E Tests

- [x] Adjusted the E2E tests according to updated NEB logic.

## Manual Test

Imported records with NEB successfully


![image](https://github.com/user-attachments/assets/75b163bd-090d-4a61-95df-8cea4b496255)
  • Loading branch information
dheepak-aot authored Nov 1, 2024
1 parent 47cc7d9 commit 20389ad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ describe(describeProcessorRootTest(QueueNames.SFASIntegration), () => {
ppdStatusDate: "1967-07-22",
msfaaNumber: "9876543210",
msfaaSignedDate: "2024-07-12",
neb: 5000,
neb: 50,
bcgg: 5000,
lfp: 7560.5,
pal: 7560.5,
Expand All @@ -376,7 +376,7 @@ describe(describeProcessorRootTest(QueueNames.SFASIntegration), () => {
ppdStatusDate: null,
msfaaNumber: "9876543211",
msfaaSignedDate: "2024-07-13",
neb: 5000,
neb: 50,
bcgg: 5000,
lfp: 11040,
pal: 11040,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export class SFASIndividualRecord extends SFASRecordIdentification {
* Total Nurses Education Bursary (special_program_award.program_awd_cents, award_cde = "SP04").
*/
get neb(): number {
return +this.line.substring(131, 141);
return parseDecimal(this.line.substring(131, 141));
}
/**
* BC Completion Grant for Graduates (individual_award.award_dlr, award_cde = "BCGG").
Expand Down

0 comments on commit 20389ad

Please sign in to comment.