Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2370 - Institution Read-Only User Type #4197

Merged
merged 2 commits into from
Jan 3, 2025
Merged

#2370 - Institution Read-Only User Type #4197

merged 2 commits into from
Jan 3, 2025

Conversation

andrepestana-aot
Copy link
Collaborator

@andrepestana-aot andrepestana-aot commented Jan 2, 2025 •
edited
Loading

  • Added read-only-user to the table sims.institution_user_type_roles

Migration revert:
image

@andrepestana-aot andrepestana-aot changed the title #2370 - Institution Read-Only User Type PART 1 (available functionality) #2370 - Institution Read-Only User Type Jan 2, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 22.22% ( 3782 / 17020 )
Methods: 10.19% ( 219 / 2150 )
Lines: 25.66% ( 3277 / 12770 )
Branches: 13.62% ( 286 / 2100 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.59% ( 589 / 898 )
Methods: 59.63% ( 65 / 109 )
Lines: 68.72% ( 468 / 681 )
Branches: 51.85% ( 56 / 108 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 86.14% ( 1249 / 1450 )
Methods: 82.42% ( 136 / 165 )
Lines: 88.51% ( 1032 / 1166 )
Branches: 68.07% ( 81 / 119 )

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@andrepestana-aot andrepestana-aot self-assigned this Jan 3, 2025
@andrepestana-aot andrepestana-aot added DB DB migration involved Institution Institution Features labels Jan 3, 2025
@andrepestana-aot andrepestana-aot marked this pull request as ready for review January 3, 2025 00:30
andrewsignori-aot
andrewsignori-aot approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@andrewsignori-aot andrewsignori-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

lewischen-aot
lewischen-aot approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@lewischen-aot lewischen-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrepestana-aot andrepestana-aot added this pull request to the merge queue Jan 3, 2025
Merged via the queue into main with commit 9bc96d8 Jan 3, 2025
21 checks passed
@andrepestana-aot andrepestana-aot deleted the 2370_institution_readonly_usertype_part1 branch January 3, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewischen-aot lewischen-aot lewischen-aot approved these changes

@andrewsignori-aot andrewsignori-aot andrewsignori-aot approved these changes

Assignees

@andrepestana-aot andrepestana-aot

Labels
DB DB migration involved Institution Institution Features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrepestana-aot @andrewsignori-aot @lewischen-aot