Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4202 - Increment Sequence Header PT ECert #4208

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

sh16011993
Copy link
Collaborator

@sh16011993 sh16011993 commented Jan 6, 2025

As a part of this PR, the following were completed:

  • Ensured that the sequence numbers in PT and FT eCert file header is incremented as a lifetime value.
  • Started the next PROD sequence number at 7 for PT eCerts and FT eCerts are left as is (set to start at 1). For this, added the following SQL to the Release 2.2 notes:
INSERT INTO sims.sequence_controls
(sequence_name, sequence_number)
VALUES ('ECERT_PT_SENT_FILE', 6), ('ECERT_FT_SENT_FILE', 0);

Screenshots:

image
image

@sh16011993 sh16011993 self-assigned this Jan 6, 2025
@sh16011993 sh16011993 added Queue Consumers Release Instructions Some Instruction got added to the release notes labels Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 7, 2025

Copy link

github-actions bot commented Jan 7, 2025

Backend Unit Tests Coverage Report

Totals Coverage
Statements: 21.94% ( 3788 / 17262 )
Methods: 9.98% ( 219 / 2194 )
Lines: 25.3% ( 3283 / 12976 )
Branches: 13.67% ( 286 / 2092 )

Copy link

github-actions bot commented Jan 7, 2025

E2E Workflow Workers Coverage Report

Totals Coverage
Statements: 65.43% ( 583 / 891 )
Methods: 59.26% ( 64 / 108 )
Lines: 68.54% ( 464 / 677 )
Branches: 51.89% ( 55 / 106 )

Copy link

github-actions bot commented Jan 7, 2025

E2E Queue Consumers Coverage Report

Totals Coverage
Statements: 80% ( 1336 / 1670 )
Methods: 63.55% ( 136 / 214 )
Lines: 83.49% ( 1123 / 1345 )
Branches: 69.37% ( 77 / 111 )

Copy link

github-actions bot commented Jan 7, 2025

E2E SIMS API Coverage Report

Totals Coverage
Statements: 67.4% ( 5922 / 8787 )
Methods: 65.09% ( 729 / 1120 )
Lines: 71.33% ( 4647 / 6515 )
Branches: 47.4% ( 546 / 1152 )

@dheepak-aot
Copy link
Collaborator

The following part is not required in the release instructions SQL ('ECERT_FT_SENT_FILE', 0)

Copy link
Collaborator

@dheepak-aot dheepak-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the changes @sh16011993. Looks good.

Anyone looking for previous review comments, are on the closed PR.

#4206

Copy link
Collaborator

@andrepestana-aot andrepestana-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great job!

@sh16011993 sh16011993 merged commit 9415894 into release/v2.2.0 Jan 7, 2025
21 checks passed
@sh16011993 sh16011993 deleted the 4202_Increment_sequence_header_PT_ecert branch January 7, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants