Remove Patroni and backup files and makefile commands from SIMS repository #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2025 15:34
guru-aot
changed the title
bidyashish
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Looks good, Nice work @guru-aot
Btw, I find few old place still referencing Patroni, not sure if those are to be deleted too?
Those are for crunchy installations and no need to be removed @bidyashish |
andrewsignori-aot
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Thanks for the cleanup, looks good 👍
Minor but the below mention can be removed/changed.
https://github.com/bcgov/SIMS/blob/542192b7fc4e1e9215d394f7d9c8ab9b3e341889/docs/technologies-overview.md
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Patroni deployment and backup files, makefile commands from SIMS repository.