#3910 - Show application edit history ministry view #4213

lewischen-aot · 2025-01-08T00:03:51Z

Created the menu on demand, only if any historical application exists.
- Modify application view screen to have all versions of the app history on the left hand side.
- Each version of the app will be a expandable selection.
- Each app version will appear in descending order based on date time stamp.
- Each application will open its application form upon clicking.
Added a new API endpoint for fetching historical applications to populate the menu.
Changed the API to allow the overwritten application information needed to build the menu for Ministry User.
- Ensured API would allow the overwritten applications to be retrieved.
Modified and added E2E tests for the changed API endpoints.

Screenshot of the historical application items

...s/packages/backend/apps/api/src/route-controllers/application/application.aest.controller.ts

sources/packages/backend/apps/api/src/route-controllers/application/models/application.dto.ts

...s/packages/backend/apps/api/src/route-controllers/application/application.aest.controller.ts

sources/packages/backend/apps/api/src/services/application/application.service.ts

sources/packages/backend/libs/utilities/src/date-utils.ts

sources/packages/web/src/components/layouts/aest/AESTApplicationSideBar.vue

dheepak-aot · 2025-01-08T21:16:23Z

sources/packages/web/src/services/ApplicationService.ts

+   */
+  async getApplicationVersionHistory(
+    applicationId: number,
+  ): Promise<ApplicationVersionAPIOutDTO[]> {


Please take care of DTO as per previous discussions in service and API.

sources/packages/web/src/services/http/ApplicationApi.ts

sources/packages/backend/apps/api/src/services/application/application.service.ts

...s/packages/backend/apps/api/src/route-controllers/application/application.aest.controller.ts

dheepak-aot · 2025-01-10T16:06:44Z

sources/packages/web/src/components/layouts/aest/AESTApplicationSideBar.vue

+          <v-list-item v-bind="props" :title="application.title"></v-list-item>
+        </template>
+        <v-list-item
+          v-for="child in application.children"


I am able to see that, when the scrollbar appears in nav(which occupies some width), the time (counter 1 in screenshot) is hidden in the group headers. If we remove the Icon(counter 2 in screenshot), it will solve this problem. Is the icon really essential for business?

sources/packages/web/src/types/AppRoutes.ts

dheepak-aot · 2025-01-10T16:09:38Z

sources/packages/web/src/router/AESTRoutes.ts

+            path: AppRoutes.ApplicationVersionDetail,
+            name: AESTRoutesConst.APPLICATION_VERSION_DETAILS,


Thanks for doing the testing, finding the issue and the fix. 👍

dheepak-aot · 2025-01-10T16:18:18Z

sources/packages/web/src/router/AESTRoutes.ts

+            path: AppRoutes.ApplicationVersionDetail,
+            name: AESTRoutesConst.APPLICATION_VERSION_DETAILS,
+            props: true,
+            component: StudentApplicationView,


Now that we send the versionid we have to make a minor adjustment in StudentApplicationView.vue otherwise the API call to get application data will always use the applicationId and not the versionId.

Issue:

My best suggestion on solution:

dheepak-aot · 2025-01-10T16:22:35Z

Thanks for doing the changes. Almost there added few more comments.

dheepak-aot · 2025-01-10T21:42:07Z

sources/packages/web/src/views/aest/StudentApplicationView.vue

@@ -45,6 +45,10 @@ export default defineComponent({
      type: Number,
      required: true,
    },
+    versionApplicationId: {
+      type: Number,
+      required: true,


My bad. In the screenshot I shared, I kept the required: true by mistake , but the required must be false.

sonarqubecloud · 2025-01-10T21:52:56Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-01-10T21:53:53Z

Backend Unit Tests Coverage Report

Totals
Statements:	22.21% ( 3783 / 17033 )
Methods:	10.17% ( 219 / 2153 )
Lines:	25.65% ( 3278 / 12778 )
Branches:	13.61% ( 286 / 2102 )

github-actions · 2025-01-10T21:54:15Z

E2E Workflow Workers Coverage Report

Totals
Statements:	65.59% ( 589 / 898 )
Methods:	59.63% ( 65 / 109 )
Lines:	68.72% ( 468 / 681 )
Branches:	51.85% ( 56 / 108 )

github-actions · 2025-01-10T21:56:37Z

E2E Queue Consumers Coverage Report

Totals
Statements:	86.14% ( 1249 / 1450 )
Methods:	82.42% ( 136 / 165 )
Lines:	88.51% ( 1032 / 1166 )
Branches:	68.07% ( 81 / 119 )

dheepak-aot

Thanks for doing the changes. Great work. 👍

sh16011993

Great work @lewischen-aot 👍

github-actions · 2025-01-10T21:59:23Z

E2E SIMS API Coverage Report

Totals
Statements:	67.45% ( 5938 / 8803 )
Methods:	65.18% ( 732 / 1123 )
Lines:	71.37% ( 4657 / 6525 )
Branches:	47.53% ( 549 / 1155 )

new E2E test file for getApplicationVersionHistory

14d62f5

lewischen-aot self-assigned this Jan 8, 2025

lewischen-aot added Enhancement New feature or request User Story SIMS-Api SIMS-Api Web portal Usability labels Jan 8, 2025

lewischen-aot added 3 commits January 7, 2025 16:16

fixed e2e test

ad203f6

exclude current application

9f89b42

fix e2e tests

d780ea3

lewischen-aot marked this pull request as ready for review January 8, 2025 01:14

dheepak-aot self-requested a review January 8, 2025 18:20