Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for click on gateway error #1217

Merged
merged 5 commits into from
Jan 13, 2025
Merged

fix for click on gateway error #1217

merged 5 commits into from
Jan 13, 2025

Conversation

ikethecoder
Copy link
Member

@ikethecoder ikethecoder commented Jan 7, 2025

Copy link
Contributor

@Elson9 Elson9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and working well with fixing the redirect issue. Also redirects to the list page when a gateway isn't selected (i.e. when trying to access the detail page on first login)

@rustyjux
Copy link
Contributor

rustyjux commented Jan 7, 2025

Clean and simple. Works well on feature deployment and local, hopefully it holds true!

It seems like in instances where we have namespace.isFetching || namespace.isLoading as a condition, the isLoading part is redundant since isFetching includes the initial load (unlike isRefetching which is only refetches). I made a small commit to reflect this; tested locally and the skeleton still shows when expected.

@ikethecoder ikethecoder merged commit 5fca87f into dev Jan 13, 2025
7 checks passed
@ikethecoder ikethecoder deleted the feature/click-on-gateway branch January 13, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on gateway list entry doesn't always redirect
3 participants