Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Find Telemetry #1434

Merged
merged 9 commits into from
Nov 28, 2024
Merged

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Nov 19, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • Update telemetry find endpoint and summary list components.
  • Update summary container loading animation triggers
  • Tweak StyledDataGrid.tsx css

Testing Notes

  • The Telemetry section of the Summary page should work as expected, including all of the filter controls.
  • The other sections on the summary page should not have been changed in any major ways, and should also still work as they did before.

- Update summary container loading animation triggers
- Tweak StyledDataGrid.tsx css
@NickPhura NickPhura requested a review from MacQSL November 19, 2024 19:58
Add/fix telemetry api tests.
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 117 lines in your changes missing coverage. Please review.

Please upload report for BASE (SIMSBIOHUB-627@9f7d521). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...emetry-repositories/telemetry-vendor-repository.ts 3.40% 85 Missing ⚠️
.../tabular-data/telemetry/TelemetryListContainer.tsx 0.00% 11 Missing ⚠️
...ummary/list-data/project/ProjectsListContainer.tsx 0.00% 7 Missing ⚠️
...p/src/components/fields/MultiAutocompleteField.tsx 0.00% 3 Missing ⚠️
api/src/paths/telemetry/index.ts 60.00% 0 Missing and 2 partials ⚠️
...rt-services/telemetry/export-telemetry-strategy.ts 33.33% 2 Missing ⚠️
.../summary/list-data/survey/SurveysListContainer.tsx 0.00% 2 Missing ⚠️
...mmary/tabular-data/animal/AnimalsListContainer.tsx 0.00% 2 Missing ⚠️
...lar-data/observation/ObservationsListContainer.tsx 0.00% 2 Missing ⚠️
...tabular-data/telemetry/TelemetryListFilterForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             SIMSBIOHUB-627    #1434   +/-   ##
=================================================
  Coverage                  ?   45.38%           
=================================================
  Files                     ?      887           
  Lines                     ?    23189           
  Branches                  ?     3376           
=================================================
  Hits                      ?    10525           
  Misses                    ?    12068           
  Partials                  ?      596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NickPhura NickPhura marked this pull request as draft November 20, 2024 00:26
@NickPhura NickPhura added the Ready For Review PR is ready for review label Nov 20, 2024
@NickPhura NickPhura marked this pull request as ready for review November 27, 2024 21:14
Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed the code and poked around the UI,

Looks good to me

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
13.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@NickPhura NickPhura merged commit fdc21f7 into SIMSBIOHUB-627 Nov 28, 2024
19 of 20 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-627-find-telemetry branch November 28, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants