Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-627: Migrate BCTW Feature Branch #1437

Merged
merged 62 commits into from
Dec 17, 2024
Merged

SIMSBIOHUB-627: Migrate BCTW Feature Branch #1437

merged 62 commits into from
Dec 17, 2024

Conversation

NickPhura
Copy link
Collaborator

@NickPhura NickPhura commented Nov 28, 2024

Links to Jira Tickets

https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-627

Description of Changes

Upgrades to SIMS to support the important BCTW features, as part of deprecating the standalone BCTW application.

Testing Notes

QA everything..

Other

Will need to be coordinated with a data ETL from BCTW prod. See comment/attachment in linked Jira ticket.

NickPhura and others added 30 commits October 8, 2024 17:12
- Telemetry Device CRUD operations
- Vendor Telemetry Repo + Service
- getTelemetryByDeployment + getTelemetryByDeployments
Add deployments CRUD and endpoints.
* Move and rename deployment service/repo
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 58.67099% with 510 lines in your changes missing coverage. Please review.

Project coverage is 45.59%. Comparing base (4c79a59) to head (77e9a3a).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...emetry-repositories/telemetry-vendor-repository.ts 5.76% 147 Missing ⚠️
app/src/contexts/telemetryTableContext.tsx 3.12% 31 Missing ⚠️
.../src/components/fields/DeviceAutocompleteField.tsx 0.00% 29 Missing ⚠️
...ry-repositories/telemetry-deployment-repository.ts 58.73% 25 Missing and 1 partial ⚠️
...emetry-repositories/telemetry-device-repository.ts 62.00% 19 Missing ⚠️
...emetry-repositories/telemetry-manual-repository.ts 17.39% 19 Missing ⚠️
...{projectId}/survey/{surveyId}/telemetry/spatial.ts 0.00% 18 Missing ⚠️
...survey/{surveyId}/telemetry/{telemetryId}/index.ts 0.00% 18 Missing ⚠️
...s/telemetry-repositories/telemetry-device-utils.ts 11.11% 16 Missing ⚠️
...ices/telemetry-services/telemetry-lotek-service.ts 80.95% 9 Missing and 3 partials ⚠️
... and 45 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1437      +/-   ##
==========================================
- Coverage   46.02%   45.59%   -0.44%     
==========================================
  Files         849      883      +34     
  Lines       22431    23256     +825     
  Branches     3335     3429      +94     
==========================================
+ Hits        10324    10603     +279     
- Misses      11494    12043     +549     
+ Partials      613      610       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Dec 11, 2024
@NickPhura NickPhura marked this pull request as ready for review December 11, 2024 18:14
* Minor UI cleanup/tweaks.
* Update delete survey procedure
* Delete old bctw-related api code
* Fix telemetry credential upload endpoint
* Fix Manual telemetry create, edit, delete.
* Update backend service/repo functions. Remove some duplicate code.
* Add telemetry pagination/sorting.
* Add placeholder when critterbase record cant be found.
* Disable telemetry import button (temporarily)
* chore: deprecating bctw related code
* fix: dropped telemetry context provider and custom hook

---------

Co-authored-by: Mac Deluca <[email protected]>
NickPhura and others added 2 commits December 16, 2024 17:03
* Add tabs to survey telemetry spatial table.
* Update Survey spatial components (telemetry)
* Change deployments2 to deployments
* Remove more deprecated env vars
* dropped telemetryContext + useTelemetryContext
* Fix telemetry sorting

---------

Co-authored-by: Mac Deluca <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@MacQSL MacQSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickPhura NickPhura merged commit 6454ffd into dev Dec 17, 2024
22 of 24 checks passed
@NickPhura NickPhura deleted the SIMSBIOHUB-627 branch December 17, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants