Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-647: Create Observations Page #1444

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Dec 3, 2024

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • Allows observations to be added from a dedicated page

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

TODO

  • Test the create endpoint (the frontend data may have changed slightly, make sure observations still save)
  • Update the sampling dropdown fields so they match the style of the other dropdowns (make them less narrow)\
  • Check frontend tests
  • Check backend tests

@mauberti-bc mauberti-bc added the Not Ready For Review Addressing feedback and/or refactoring label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 1.09290% with 543 lines in your changes missing coverage. Please review.

Project coverage is 44.97%. Comparing base (e22292d) to head (d72a7aa).

Files with missing lines Patch % Lines
...nts/sampling/hooks/useSamplingInformationCache.tsx 0.00% 87 Missing ⚠️
...veys/observations/create/CreateObservationPage.tsx 0.00% 61 Missing ⚠️
...onents/sampling/components/SamplingPeriodField.tsx 0.00% 54 Missing ⚠️
...nents/sampling/components/MethodTechniqueField.tsx 0.00% 52 Missing ⚠️
...mponents/sampling/components/SamplingSiteField.tsx 0.00% 40 Missing ⚠️
...onents/environments/ObservationEnvironmentForm.tsx 0.00% 34 Missing ⚠️
...ations/form/components/subcounts/SubcountsForm.tsx 0.00% 30 Missing ⚠️
.../dual-autocomplete-field/DualAutocompleteField.tsx 0.00% 21 Missing ⚠️
...projectId}/survey/{surveyId}/observations/index.ts 20.00% 20 Missing ⚠️
app/src/hooks/useFocalOrObservedTsns.tsx 0.00% 20 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1444      +/-   ##
==========================================
- Coverage   45.92%   44.97%   -0.95%     
==========================================
  Files         907      929      +22     
  Lines       23537    24043     +506     
  Branches     3492     3594     +102     
==========================================
+ Hits        10809    10814       +5     
- Misses      12136    12637     +501     
  Partials      592      592              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc added Early Feedback Welcome PR is not finished, but early review feedback is welcomed and removed Not Ready For Review Addressing feedback and/or refactoring labels Jan 8, 2025
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Jan 16, 2025
@NickPhura
Copy link
Collaborator

I pushed up a few misc changes. Mostly just some component cleanup and addressing a few react dependency complaints, etc.

@NickPhura NickPhura added Early Feedback Welcome PR is not finished, but early review feedback is welcomed and removed Ready For Review PR is ready for review labels Jan 20, 2025
mauberti-bc and others added 2 commits January 21, 2025 10:06
wip

wip: create location and date sections on form

wip: style subcount form

wip: adding measurements to subcounts

add dual autocomplete

subcount form

subcount table on create observation page

fix measurement search

show measurement options in subcount table on create observation page

wip: formik validation

add subcount sign placeholder to create request

wip: environments incorrectly formatted in handlesubmit

fix incorrect key

fix environments on create observations page

fix measurement interfaces

SIMSBIOHUB-659: Add Pagination to System Alerts on Admin Page (#1459)

Add Pagination to System Alerts on Admin Page

---------

Co-authored-by: Nick Phura <[email protected]>

Update CSV Error Import Dialog Styling (#1456)

- update csv import error dialog
- replace failure snackbar & add frontend pagination to csv import errors

BugFix: Fix Type for Capture Attachments (#1460)

- modifying critter index file

---------

Co-authored-by: Macgregor Aubertin-Young <[email protected]>
Co-authored-by: Macgregor Aubertin-Young <[email protected]>

BugFix: Method Attributes SQL (#1462)

- fix sql

Added DualAutocompleteUnitField.tsx to help reduce the size of the DualAutocompleteField.tsx.
Renamed some of the dual autocomplete field props, just to make them more consistent/predictable.
Fixed missing props in create/edit technique vantages (missing category data type prop).
Add formik snackbar error component to observation form.
Addressed a few react missing dependency warnings.

Update missed jsdoc comments.

Update missed jsdoc comments 2.

WIP: Add create observation sampling fields.

Working sampling fields.

Enhancements to sampling fields
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
19.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants