Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSV Error Import Dialog Styling #1456

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Conversation

mauberti-bc
Copy link
Collaborator

Links to Jira Tickets

  • N/A

Description of Changes

  • Replaces the data grid of errors with a stack of cards
  • Updates the solution text for missing columns or unknown columns to include the column name

@mauberti-bc mauberti-bc added the Ready For Review PR is ready for review label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 45.96%. Comparing base (961f452) to head (a9870c5).

Files with missing lines Patch % Lines
app/src/components/csv/CSVErrorsCardStack.tsx 0.00% 20 Missing ⚠️
app/src/components/csv/CSVSingleImportDialog.tsx 0.00% 2 Missing ⚠️
app/src/components/alert/AlertBar.tsx 0.00% 1 Missing ⚠️
app/src/components/csv/CSVDropzoneSection.tsx 0.00% 1 Missing ⚠️
...src/components/csv/CSVErrorsCardStackContainer.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1456      +/-   ##
==========================================
- Coverage   45.97%   45.96%   -0.01%     
==========================================
  Files         910      909       -1     
  Lines       23698    23702       +4     
  Branches     3493     3498       +5     
==========================================
  Hits        10895    10895              
- Misses      12189    12193       +4     
  Partials      614      614              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

<Typography variant="body2">{error.header ?? 'N/A'}</Typography>
</Stack>
<Stack>
<Typography variant="body2" fontWeight={700}>
Copy link
Collaborator

@MacQSL MacQSL Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: The previous version also handled "values", which are the available options the user can enter for the specific cell (if applicable). ie: ['red', 'blue', ...]
CSVErrorsTableOptionsMenu

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants