Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-654: Captures #1457

Open
wants to merge 114 commits into
base: dev
Choose a base branch
from
Open

SIMSBIOHUB-654: Captures #1457

wants to merge 114 commits into from

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Jan 10, 2025

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

  • {List all relevant code changes. Include any changes to the business workflow that might not be obvious to the reviewers of this PR.}

Testing Notes

  • {List any relevant testing considerations, necessary pre-reqs, and areas of the app to focus on. Specifically, include anything that will help the reviewers of this PR verify the code is functioning as expected.}

@MacQSL MacQSL added the Ready For Review PR is ready for review label Jan 10, 2025
@MacQSL MacQSL requested a review from NickPhura January 10, 2025 00:56
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 46.11%. Comparing base (961f452) to head (2963750).

Files with missing lines Patch % Lines
.../import-services/capture/capture-header-configs.ts 81.25% 1 Missing and 2 partials ⚠️
...import-services/capture/import-captures-service.ts 93.18% 1 Missing and 2 partials ⚠️
api/src/utils/csv-utils/csv-config-validation.ts 62.50% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1457      +/-   ##
==========================================
+ Coverage   45.97%   46.11%   +0.14%     
==========================================
  Files         910      910              
  Lines       23698    23737      +39     
  Branches     3493     3495       +2     
==========================================
+ Hits        10895    10947      +52     
+ Misses      12189    12175      -14     
- Partials      614      615       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants