Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-661: Add Filters and Pagination to Active Users Table #1463

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

mauberti-bc
Copy link
Collaborator

@mauberti-bc mauberti-bc commented Jan 16, 2025

Links to Jira Tickets

  • {Include a link to all applicable Jira tickets}

Description of Changes

@mauberti-bc mauberti-bc added the Not Ready For Review Addressing feedback and/or refactoring label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 44.65409% with 88 lines in your changes missing coverage. Please review.

Project coverage is 46.05%. Comparing base (e22292d) to head (931fd41).

Files with missing lines Patch % Lines
...s/admin/users/active/ActiveUsersTableContainer.tsx 35.52% 45 Missing and 4 partials ⚠️
api/src/repositories/user-repository.ts 44.44% 10 Missing and 5 partials ⚠️
...ures/admin/users/active/table/ActiveUsersTable.tsx 38.09% 13 Missing ⚠️
...min/users/active/filters/ActiveUsersFilterForm.tsx 52.63% 8 Missing and 1 partial ⚠️
api/src/paths/user/list.ts 81.81% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1463      +/-   ##
==========================================
+ Coverage   45.92%   46.05%   +0.13%     
==========================================
  Files         907      909       +2     
  Lines       23537    23585      +48     
  Branches     3492     3501       +9     
==========================================
+ Hits        10809    10862      +53     
+ Misses      12136    12121      -15     
- Partials      592      602      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mauberti-bc mauberti-bc added Ready For Review PR is ready for review Not Ready For Review Addressing feedback and/or refactoring and removed Not Ready For Review Addressing feedback and/or refactoring Ready For Review PR is ready for review labels Jan 22, 2025
@mauberti-bc mauberti-bc marked this pull request as ready for review January 22, 2025 20:08
@mauberti-bc mauberti-bc added Ready For Review PR is ready for review and removed Not Ready For Review Addressing feedback and/or refactoring labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant