Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24772 - Update NoW Schema #172

Merged
merged 3 commits into from
Jan 23, 2025
Merged

24772 - Update NoW Schema #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6c3dcd
24772-Update-NoW-Schema-and-data-with-new-properties
meawong Jan 22, 2025
a1fe00b
24772-Change-id-to-singular
meawong Jan 22, 2025
b815919
24772-Update titles for new properties
meawong Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/registry_schemas/example_data/schema_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2889,7 +2889,9 @@

NOTICE_OF_WITHDRAWAL = {
'filingId': 123,
'courtOrder': COURT_ORDER
'courtOrder': COURT_ORDER,
'hasTakenEffect': False,
'partOfPoa': False
argush3 marked this conversation as resolved.
Show resolved Hide resolved
}

# build complete list of filings with names, for use in the generic test_valid_filing() test
Expand Down
12 changes: 10 additions & 2 deletions src/registry_schemas/schemas/notice_of_withdrawal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,17 @@
"properties": {
"filingId": {
"type": "integer",
"title": "IDs for the FED filings."
"title": "ID for the FED filing."
},
"courtOrder": { "$ref": "https://bcrs.gov.bc.ca/.well_known/schemas/court_order#/properties/courtOrder" }
"courtOrder": { "$ref": "https://bcrs.gov.bc.ca/.well_known/schemas/court_order#/properties/courtOrder"},
"hasTakenEffect": {
"type": "boolean",
"title": "One of the terms of arrangement for the FED filing have taken effect"
},
"partOfPoa": {
"type": "boolean",
"title": "FED filing is part of a Plan of Arrangement"
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/registry_schemas/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@
"""


__version__ = '2.18.32' # pylint: disable=invalid-name
__version__ = '2.18.33' # pylint: disable=invalid-name
Loading