Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Lock Summary on Submit #1653

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

dhaselhan
Copy link
Collaborator

  • Copy over is_locked flag on update method to summary
  • Remove old unused lock method
  • Remove before_update trigger as we reports can be unlocked now

* Copy over is_locked flag on update method to summary
* Remove old unused lock method
* Remove before_update trigger as we reports can be unlocked now
@dhaselhan dhaselhan requested a review from AlexZorkin January 9, 2025 23:52
Copy link

github-actions bot commented Jan 9, 2025

Frontend Test Results

  1 files  ±0  123 suites  ±0   43s ⏱️ -1s
428 tests ±0  408 ✅ ±0  20 💤 ±0  0 ❌ ±0 
430 runs  ±0  410 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit bfaa08e. ± Comparison against base commit 336f089.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 9, 2025

Backend Test Results

503 tests  ±0   503 ✅ ±0   1m 42s ⏱️ -2s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit bfaa08e. ± Comparison against base commit 336f089.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@prv-proton prv-proton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@dhaselhan dhaselhan merged commit 8e93299 into release-0.2.0 Jan 14, 2025
1 check passed
@dhaselhan dhaselhan deleted the fix/daniel-lock-summary-on-submit-1643 branch January 14, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants