-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCFS-1659: Incorrect fuel type list in Fuels for other use #1658
Merged
areyeslo
merged 5 commits into
release-0.2.0
from
LCFS-1207-AddFuelCodeCIColumnsFuelsOtherUse_v2
Jan 16, 2025
Merged
LCFS-1659: Incorrect fuel type list in Fuels for other use #1658
areyeslo
merged 5 commits into
release-0.2.0
from
LCFS-1207-AddFuelCodeCIColumnsFuelsOtherUse_v2
Jan 16, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areyeslo
changed the title
LCFS-1207: Add Fuel code and CI columns to Fuels for other use grid
LCFS-1659: Incorrect fuel type list in Fuels for other use
Jan 10, 2025
prv-proton
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revision head out of sync
prv-proton
reviewed
Jan 14, 2025
areyeslo
force-pushed
the
LCFS-1207-AddFuelCodeCIColumnsFuelsOtherUse_v2
branch
from
January 14, 2025 23:10
cc9d106
to
dd0aaa2
Compare
prv-proton
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
areyeslo
force-pushed
the
LCFS-1207-AddFuelCodeCIColumnsFuelsOtherUse_v2
branch
from
January 16, 2025 20:22
9b64428
to
ef67759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is focused on getting the correct list in fuel_type. The data might be changed in Dev and affected the list shown in the dropdown.
In addition, added clearing provisionOfTheAct when changing fuel_type.
Note: Renewable naphtha is not included because its fuel code is expired.
Story