Skip to content

Commit

Permalink
21696-fix broken code coverage uploads in CIs (#2767)
Browse files Browse the repository at this point in the history
* fix Codecov upload issues - change to v4, add token, add Codecov section for 2 jobs

* add multiple flags to codegov.yaml, remove datareset flag
  • Loading branch information
eason-pan-bc authored Jun 18, 2024
1 parent bca5088 commit 6192b01
Show file tree
Hide file tree
Showing 9 changed files with 47 additions and 10 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/colin-api-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,12 @@ jobs:
run: |
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
file: ./colin-api/coverage.xml
flags: colinapi
name: codecov-colin-api
token: ${{ secrets.CODECOV_TOKEN}}
fail_ci_if_error: true

build-check:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/entity-bn-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,12 @@ jobs:
run: |
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
file: ./queue_services/entity-bn/coverage.xml
flags: entitybn
name: codecov-entity-bn
token: ${{ secrets.CODECOV_TOKEN}}
fail_ci_if_error: true

build-check:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/entity-digital-credentials-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,12 @@ jobs:
run: |
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
file: ./queue_services/entity-digital-credentials/coverage.xml
flags: entity-digital-credentials
name: codecov-entity-digital-credentials
token: ${{ secrets.CODECOV_TOKEN}}
fail_ci_if_error: true

build-check:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/entity-emailer-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,12 @@ jobs:
run: |
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
file: ./queue_services/entity-emailer/coverage.xml
flags: entityemailer
name: codecov-entity-emailer
token: ${{ secrets.CODECOV_TOKEN}}
fail_ci_if_error: true

build-check:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/entity-filer-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,12 @@ jobs:
run: |
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
file: ./queue_services/entity-filer/coverage.xml
flags: entityfiler
name: codecov-entity-filer
token: ${{ secrets.CODECOV_TOKEN}}
fail_ci_if_error: true

build-check:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/entity-pay-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,12 @@ jobs:
run: |
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
with:
file: ./queue_services/entity-pay/coverage.xml
flags: entitypay
name: codecov-entity-pay
token: ${{ secrets.CODECOV_TOKEN}}
fail_ci_if_error: true

build-check:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/furnishings-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,14 @@ jobs:
id: test
run: |
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
with:
file: ./jobs/furnishings/coverage.xml
flags: furnishings
name: codecov-furnishings
token: ${{ secrets.CODECOV_TOKEN}}
fail_ci_if_error: true

build-check:
needs: setup-job
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/involuntary-dissolutions-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,14 @@ jobs:
id: test
run: |
make test
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
with:
file: ./jobs/involuntary-dissolutions/coverage.xml
flags: involuntary-dissolutions
name: codecov-involuntary-dissolutions
token: ${{ secrets.CODECOV_TOKEN}}
fail_ci_if_error: true

build-check:
needs: setup-job
Expand All @@ -98,4 +106,4 @@ jobs:
- name: build to check strictness
id: build
run: |
make build-nc
make build-nc
21 changes: 18 additions & 3 deletions codecov.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@ coverage:
- entityemailer
- entityfiler
- entitypay
- datareset
- entitybn
- entity-digital-credentials
- furnishings
- involuntary-dissolutions

ignore:
- "^/tests/**/*" # ignore test harness code
Expand Down Expand Up @@ -57,7 +60,19 @@ flags:
paths:
- queue_services/entity-pay/src/entity_pay
carryforward: true
datareset:
entitybn:
paths:
- data-reset-tool/src/data_reset_tool
- queue_services/entity-bn/src/entity_bn
carryforward: true
entity-digital-credentials:
paths:
- queue_services/entity-digital-credentials/src/entity_digital_credentials
carryforward: true
furnishings:
paths:
- jobs/furnishings
carryforward: true
involuntary-dissolutions:
paths:
- jobs/involuntary-dissolutions
carryforward: true

0 comments on commit 6192b01

Please sign in to comment.