Fixed in response to Argus' comments

bcgov · Nov 27, 2023 · 8ea69f6 · 8ea69f6
1 parent 4d07f03
commit 8ea69f6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/queue_services/entity-emailer/src/entity_emailer/message_tracker/tracker.py b/queue_services/entity-emailer/src/entity_emailer/message_tracker/tracker.py
@@ -89,15 +89,7 @@ def get_message_context_properties(queue_msg: nats.aio.client.Msg):
             message_id = f'{etype}_{option}_{ar_year}_{business_id}'
             return create_message_context_properties(etype, message_id, None, None, False)
 
-        if etype == 'agmLocationChange' \
-                and (option := email.get('option', None)) \
-                and option == 'COMPLETED' \
-                and (filing_id := email.get('filingId', None)):
-            # option contains current status of filing - COMPLETED
-            message_id = f'{etype}_{option}_{filing_id}'
-            return create_message_context_properties(etype, message_id, None, None, False)
-
-        if etype == 'agmExtension' \
+        if etype in ('agmLocationChange', 'agmExtension') \
                 and (option := email.get('option', None)) \
                 and option == 'COMPLETED' \
                 and (filing_id := email.get('filingId', None)):

diff --git a/queue_services/entity-filer/requirements/bcregistry-libraries.txt b/queue_services/entity-filer/requirements/bcregistry-libraries.txt
@@ -1,3 +1,3 @@
-git+https://github.com/bcgov/[email protected].14#egg=registry_schemas
+git+https://github.com/bcgov/[email protected].17#egg=registry_schemas
 git+https://github.com/bcgov/lear.git#egg=legal_api&subdirectory=legal-api
 git+https://github.com/bcgov/lear.git#egg=entity_queue_common&subdirectory=queue_services/common