Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18970 - 2nd bump version number for 19.6b #2360

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

tshyun24
Copy link
Contributor

Issue #: /bcgov/entity#18970

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@tshyun24 tshyun24 self-assigned this Dec 14, 2023
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

9.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #2360 (00ee90e) into main (79511cd) will decrease coverage by 6.97%.
Report is 56 commits behind head on main.
The diff coverage is 57.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
- Coverage   77.37%   70.41%   -6.97%     
==========================================
  Files         202       26     -176     
  Lines       11602     1531   -10071     
  Branches     1961      229    -1732     
==========================================
- Hits         8977     1078    -7899     
+ Misses       2043      378    -1665     
+ Partials      582       75     -507     
Flag Coverage Δ
entityemailer 70.41% <57.05%> (?)
entityfiler ?
legalapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rvices/entity-emailer/src/entity_emailer/config.py 100.00% <100.00%> (ø)
...mailer/email_processors/correction_notification.py 76.41% <100.00%> (ø)
...iler/src/entity_emailer/message_tracker/tracker.py 83.96% <100.00%> (ø)
...vices/entity-emailer/src/entity_emailer/version.py 100.00% <100.00%> (ø)
...iler/email_processors/special_resolution_helper.py 69.64% <0.00%> (ø)
...rvices/entity-emailer/src/entity_emailer/worker.py 68.61% <0.00%> (ø)
...ler/email_processors/agm_extension_notification.py 65.38% <65.38%> (ø)
...ail_processors/agm_location_change_notification.py 65.38% <65.38%> (ø)
...entity_emailer/email_processors/nr_notification.py 69.23% <36.66%> (ø)

... and 219 files with indirect coverage changes

@tshyun24 tshyun24 merged commit 077d966 into bcgov:main Dec 14, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants