20119 Legal API - Update aliases code to work with alternate names #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenhongjing
requested review from
argush3,
kzdev420,
vysakh-menon-aot,
JazzarKarim,
leodube-aot and
tshyun24
|
Looks good so far! I just merged my unit test PR so you should be good to make the changes for the unit tests. |
Thanks! 😸 |
… names Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
|
argush3
approved these changes
Mar 14, 2024
leodube-aot
approved these changes
Mar 15, 2024
PaulGarewal
pushed a commit
to PaulGarewal/lear
that referenced
this pull request
Mar 18, 2024
…cgov#2516) * 20119 Legal API - update existing aliases code to work with alternate names Signed-off-by: Hongjing Chen <[email protected]> * update unit tests Signed-off-by: Hongjing Chen <[email protected]> * fix linting Signed-off-by: Hongjing Chen <[email protected]> * remove alias references & test_alias Signed-off-by: Hongjing Chen <[email protected]> * fix linting-2 Signed-off-by: Hongjing Chen <[email protected]> --------- Signed-off-by: Hongjing Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#20119
Description of changes:
test_alias.pyNote that current commits exclude changes for unit testsSome Tests run at local environment
GET businesses
GET aliases
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).