19942 Fix broken unit tests (report folder) #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leodube-aot
commented
Mar 15, 2024
| recognition_datetime = LegislationDatetime.as_legislation_timezone(self._legal_entity.founding_date) | ||
| if self._business: | ||
| recognition_datetime = LegislationDatetime.as_legislation_timezone( | ||
| self._business.founding_date if self._business.is_legal_entity else self._business.start_date |
There was a problem hiding this comment.
Are we okay with making recognition_date for alternate name entities be the start_date, since there is no founding_date? Or do we just not want to include the recognition date in the output for alternate names?
There was a problem hiding this comment.
yes, we can use start_date for the recognition date
|
leodube-aot
requested review from
argush3,
kzdev420,
vysakh-menon-aot,
ketaki-deodhar and
tshyun24
argush3
approved these changes
Mar 15, 2024
PaulGarewal
pushed a commit
to PaulGarewal/lear
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#19942
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).