Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20327 Fix error occurred when testing filer on GCP for registration - part 2 #2560

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

chenhongjing
Copy link
Collaborator

@chenhongjing chenhongjing commented Apr 2, 2024

Issue #: /bcgov/entity#20327

Description of changes:

  • fix issues related to find_by_id() to make sure only number can pass in
  • update status listener of filing data model so that the status of filing can be updated automatically after filing is processed by filer

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
@chenhongjing chenhongjing requested a review from argush3 April 2, 2024 20:38
@chenhongjing chenhongjing self-assigned this Apr 2, 2024
@chenhongjing chenhongjing marked this pull request as ready for review April 2, 2024 22:23
Signed-off-by: Hongjing Chen <[email protected]>
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@chenhongjing chenhongjing merged commit c485659 into bcgov:feature-legal-name Apr 3, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants