-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21331 Dissolutions Job - Implement stage 2 #2736
Conversation
@@ -39,7 +39,7 @@ clean-test: ## clean test files | |||
build-req: clean ## Upgrade requirements | |||
test -f venv/bin/activate || python3.8 -m venv $(CURRENT_ABS_DIR)/venv ;\ | |||
. venv/bin/activate ;\ | |||
pip install --upgrade pip ;\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the changes in Makefile back to previous version because it resolved the ModuleNotFoundError: No module named 'involuntary_dissolutions'
I got when running tests in local env. Also, I check that there was the same error for the last PR on dissolutions job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, weird. The --upgrade
change was a workaround for a dependency error that was happening on my mac (and maybe Argus' mac too), but obviously we don't want it breaking the unit tests.
I've been messing around with this a bit to see if I can find a middle ground where the requirements get installed correctly and the unit tests still run. I've found that pip install pip==21.0
works for both cases but throws a bunch of deprecation warnings during the tests.
I plan to keep experimenting a bit but I will make the change in my PR if I find a version that works for both cases.
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
…of week Signed-off-by: Hongjing Chen <[email protected]>
Quality Gate failedFailed conditions |
Issue #: /bcgov/entity#21331
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).