21476 update good standing logic to include transition filing criteria

[eason-pan-bc]

Issue #: /bcgov/entity#21476

Description of changes:
Implemented the logic to include transition filing logic used in involuntary dissolution eligibility check in business.good_standing.
(enable_involuntary_dissolution feature flag)

The main logic is same as the _has_no_transition_filed_after_restoration() method in involuntary dissolution.
Differences are:

• instead of checking with a given Business, this implementation checks with itself.
• instead of returning a SQLAlchemy clause, this implementation returns a boolean value, implemented using .scalar() after the query.

Also added unit tests to check 4 situations:

• New established business
• In limited restoration, not expired, no need for transition
• Transition filed and completed
• Transition not filed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (81aac8e) to head (b1bbc39).
Report is 160 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2756      +/-   ##
==========================================
+ Coverage   75.49%   76.77%   +1.28%     
==========================================
  Files         196      177      -19     
  Lines       12264    11257    -1007     
  Branches     2054     1931     -123     
==========================================
- Hits         9259     8643     -616     
+ Misses       2442     2103     -339     
+ Partials      563      511      -52     

Flag	Coverage Δ
entityemailer	?
legalapi	76.77% <100.00%> (+0.36%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
legal-api/src/legal_api/models/business.py	93.36% <100.00%> (-1.44%)	⬇️

... and 208 files with indirect coverage changes

[AimeeGao]

Except for the issues mentioned by hongjing, everything else is fine for me.

[eason-pan-bc]

Except for the issues mentioned by hongjing, everything else is fine for me.

they are all addressed now 😄

[chenhongjing]

LGTM 🐱

[AimeeGao]

All changes look good to me.