-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
21737 - Create alembic script & model for furnishings table #2761
Conversation
Signed-off-by: Hongjing Chen <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2761 +/- ##
==========================================
+ Coverage 75.49% 76.76% +1.26%
==========================================
Files 196 177 -19
Lines 12264 11245 -1019
Branches 2054 1929 -125
==========================================
- Hits 9259 8632 -627
+ Misses 2442 2103 -339
+ Partials 563 510 -53
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Looks good! Just the few comments. |
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue #: /bcgov/entity#21737
Description of changes:
db after upgrading
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).