Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21737 - Create alembic script & model for furnishings table #2761

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

chenhongjing
Copy link
Collaborator

Issue #: /bcgov/entity#21737

Description of changes:

  • Added alembic script to create furnishings table
  • Added data model for furnishing
  • Added unit tests
  • Misc updates for others

db after upgrading
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 93.05556% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.76%. Comparing base (81aac8e) to head (4247ddd).
Report is 158 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2761      +/-   ##
==========================================
+ Coverage   75.49%   76.76%   +1.26%     
==========================================
  Files         196      177      -19     
  Lines       12264    11245    -1019     
  Branches     2054     1929     -125     
==========================================
- Hits         9259     8632     -627     
+ Misses       2442     2103     -339     
+ Partials      563      510      -53     
Flag Coverage Δ
entityemailer ?
legalapi 76.76% <93.05%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
legal-api/src/legal_api/models/__init__.py 100.00% <100.00%> (ø)
legal-api/src/legal_api/models/batch.py 78.57% <100.00%> (ø)
legal-api/src/legal_api/models/furnishing.py 92.75% <92.75%> (ø)

... and 206 files with indirect coverage changes

@argush3
Copy link
Collaborator

argush3 commented Jun 18, 2024

Looks good! Just the few comments.

Copy link
Collaborator

@leodube-aot leodube-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenhongjing chenhongjing merged commit bca5088 into bcgov:main Jun 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants