-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reset by event ID endpoint for colin api requiring colin svc id #2772
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9442085 | Triggered | Generic Password | c18e478 | .github/workflows/involuntary-dissolutions-ci.yml | View secret |
9442085 | Triggered | Generic Password | c18e478 | .github/workflows/involuntary-dissolutions-ci.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2772 +/- ##
===========================================
- Coverage 75.49% 31.56% -43.94%
===========================================
Files 196 35 -161
Lines 12264 2823 -9441
Branches 2054 0 -2054
===========================================
- Hits 9259 891 -8368
+ Misses 2442 1932 -510
+ Partials 563 0 -563
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this is pretty close.
Just a few comments.
Is there a ticket for this change? If so, please tag it to Entities Sprint 22.1a Release. Thanks. |
Issue #: /bcgov/entity###
Description of changes:
Add Reset by event id endpoint to colin api. Requires the api service id. Currently only resets events caused by Business AR api calls (business filings)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).