Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reset by event ID endpoint for colin api requiring colin svc id #2772

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Add Reset by event ID endpoint for colin api requiring colin svc id #2772

merged 6 commits into from
Jun 24, 2024

Conversation

BrandonSharratt
Copy link
Contributor

Issue #: /bcgov/entity###

Description of changes:
Add Reset by event id endpoint to colin api. Requires the api service id. Currently only resets events caused by Business AR api calls (business filings)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

Copy link

gitguardian bot commented Jun 19, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9442085 Triggered Generic Password c18e478 .github/workflows/involuntary-dissolutions-ci.yml View secret
9442085 Triggered Generic Password c18e478 .github/workflows/involuntary-dissolutions-ci.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 29.78723% with 33 lines in your changes missing coverage. Please review.

Project coverage is 31.56%. Comparing base (81aac8e) to head (b704bc3).
Report is 176 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2772       +/-   ##
===========================================
- Coverage   75.49%   31.56%   -43.94%     
===========================================
  Files         196       35      -161     
  Lines       12264     2823     -9441     
  Branches     2054        0     -2054     
===========================================
- Hits         9259      891     -8368     
+ Misses       2442     1932      -510     
+ Partials      563        0      -563     
Flag Coverage Δ
colinapi 31.56% <29.78%> (?)
entityemailer ?
legalapi ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
colin-api/src/colin_api/resources/reset.py 57.14% <63.15%> (ø)
colin-api/src/colin_api/models/reset.py 18.07% <7.14%> (ø)

... and 228 files with indirect coverage changes

@thorwolpert thorwolpert requested a review from argush3 June 24, 2024 16:20
Copy link
Collaborator

@argush3 argush3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this is pretty close.

Just a few comments.

@argush3 argush3 merged commit 6ab628d into bcgov:main Jun 24, 2024
3 of 6 checks passed
@severinbeauvais
Copy link
Collaborator

Is there a ticket for this change? If so, please tag it to Entities Sprint 22.1a Release. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants