22368 Emailer - Add letter attachment to stage 1 AR email #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hongjing Chen <[email protected]>
Signed-off-by: Hongjing Chen <[email protected]>
chenhongjing
commented
Jul 29, 2024
| @@ -85,7 +92,7 @@ def get_extra_provincials(response: dict): | |||
| name = jurisdiction.get('name') | |||
| if name: | |||
| extra_provincials.append(name) | |||
|
|
|||
| extra_provincials.sort() | |||
There was a problem hiding this comment.
Add sorting so that the order presented in email will match the design.
Signed-off-by: Hongjing Chen <[email protected]>
|
argush3
reviewed
Jul 29, 2024
queue_services/entity-emailer/src/entity_emailer/email_processors/__init__.py
Show resolved
Hide resolved
argush3
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#22368
Description of changes:
q_cli.pyso that it can inject queue message for furnishings jobTesting
Note that my local testing is based on v2 of legal-api, and the email file can be downloaded at MailHog.
overdue AR without EP registration
overdue AR with EP registration
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).