Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22431 update to use v2 of legal api #2886

Merged

Conversation

kzdev420
Copy link
Collaborator

Issue #: /bcgov/entity#22431

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@kzdev420 kzdev420 self-assigned this Jul 31, 2024
@argush3
Copy link
Collaborator

argush3 commented Jul 31, 2024

Have you tested a few locally to verify that your code is able to send emails to mailhog in dev successfully using v2 of legal api?

@kzdev420
Copy link
Collaborator Author

Have you tested a few locally to verify that your code is able to send emails to mailhog in dev successfully using v2 of legal api?

I am trying to test now

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Collaborator

@argush3 argush3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.

Please verify things work as soon as this merges into main and is deployed to Dev.

@kzdev420 kzdev420 merged commit 7391119 into bcgov:main Aug 2, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants