23563 - update review endpoint #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArwenQin
approved these changes
Oct 17, 2024
vysakh-menon-aot
approved these changes
Oct 17, 2024
|
vysakh-menon-aot
approved these changes
Oct 18, 2024
chenhongjing
added a commit
that referenced
this pull request
Oct 22, 2024
* 23348 - Add allowable actions for notice of withdrawal (#3014) * Add notice of withdrawal for existing business * 23349 - validation notice of withdrawal (#3020) * implement validation logic for NoW * update schema version number in requirements * exclude the new business scenario * 23539 add batch_processing to colin_event_ids table (#3021) * 23539 add batch_processing to colin_event_ids table * add relationship, tests * fix downgrade issue * remove re-define batch_processing_step enum * 23608 - Update furnishing entries transferred to bc mail+ (#3025) * Fix bug * 23697 - fix stage1 to stage2 dissolution transition bug (#3028) * add SFTP off feature flag, modify stage 2 furnishing entry check, update tests * adjust mail status check when FF is on * add feature flag "disable-dissolution-sftp-bclaws" * refactor stage 1 furnishing entries check * update tests * 23522-23562 continuation in workflow change (#3026) * 23572 update dissolution letters (#3023) * 23572 update dissolution letters * add the dots * 23845 - Bumped version numbers up for release 23.2a (#3030) * bump version * update entity-bn version * udpate version * 23563 - update review endpoint (#3029) * 23563 - update review endpoint * 23563 - update api spec * 23563 - update api spec filing description * Undo colin_event_id model changes (#3032) --------- Co-authored-by: Aimee <[email protected]> Co-authored-by: EasonPan <[email protected]> Co-authored-by: Kevin Zhang <[email protected]> Co-authored-by: Vysakh Menon <[email protected]> Co-authored-by: ketaki-deodhar <[email protected]> Co-authored-by: leodube-aot <[email protected]>
1 task
|
looks good. should be good for publishing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#23563
Description of changes:
Removed unneeded properties like FED from filter and sort
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).