Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25159 - Update NoW filing not Saving temp_reg for T business #3170

Merged

Conversation

eason-pan-bc
Copy link
Collaborator

@eason-pan-bc eason-pan-bc commented Jan 10, 2025

Issue #: /bcgov/entity#25159

Description of changes:
This is a small change to avoid fill temp_reg field when we create a Notice of Withdrawal filing for a T business (discussion link)

Screenshots from local tests

File a NoW for a T business
image

After change, the temp_reg field is not filled when filing NoW for a T business:
image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).

@eason-pan-bc eason-pan-bc self-assigned this Jan 10, 2025
@eason-pan-bc eason-pan-bc marked this pull request as ready for review January 10, 2025 20:05
Copy link
Collaborator

@AimeeGao AimeeGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(^-^)

Copy link
Collaborator

@meawong meawong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eason-pan-bc eason-pan-bc merged commit 44a721d into bcgov:main Jan 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants