Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wfnews-1043 Add buffer to polygon and initialize map correctly #1264

Merged
merged 12 commits into from
Oct 30, 2023
Merged

wfnews-1043 Add buffer to polygon and initialize map correctly #1264

merged 12 commits into from
Oct 30, 2023

Conversation

ssylver93
Copy link
Collaborator

No description provided.

dhlevi
dhlevi approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@dhlevi dhlevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues with this architecturally, but the code looks good (you may want to simplify the bbox with turf, but that's certainly not a showstopper). I'll bring these up in the main channel

...ents/full-details/area-restrictions-full-details/area-restrictions-full-details.component.ts Outdated Show resolved Hide resolved
@ssylver93 ssylver93 merged commit 2bafce9 into bcgov:main Oct 30, 2023
@ssylver93 ssylver93 temporarily deployed to DEV October 30, 2023 17:08 — with GitHub Actions Inactive
@ssylver93 ssylver93 temporarily deployed to DEV October 30, 2023 17:08 — with GitHub Actions Inactive
@ssylver93 ssylver93 temporarily deployed to DEV October 30, 2023 17:08 — with GitHub Actions Inactive
@ssylver93 ssylver93 temporarily deployed to DEV October 30, 2023 17:08 — with GitHub Actions Inactive
@ssylver93 ssylver93 temporarily deployed to DEV October 30, 2023 17:08 — with GitHub Actions Inactive
@ssylver93 ssylver93 temporarily deployed to DEV October 30, 2023 17:08 — with GitHub Actions Inactive
@ssylver93 ssylver93 temporarily deployed to DEV October 30, 2023 17:08 — with GitHub Actions Inactive
@ssylver93 ssylver93 temporarily deployed to DEV October 30, 2023 17:08 — with GitHub Actions Inactive
@ssylver93 ssylver93 temporarily deployed to DEV October 30, 2023 17:27 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhlevi dhlevi dhlevi approved these changes

@sukhpalp sukhpalp Awaiting requested review from sukhpalp

@yzlucas yzlucas Awaiting requested review from yzlucas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssylver93 @dhlevi