Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent id 0 to be falsy value #1586

Merged
merged 1 commit into from
Feb 6, 2024
Merged

prevent id 0 to be falsy value #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...full-details/area-restrictions-full-details/area-restrictions-full-details.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="title-panel">
<div class="full-details-title">{{restrictionData.name}}</div>
<div class="full-details-title">{{restrictionData?.name}}</div>
<p class="info">A legal order that prohibits access to certain areas in order to limit the risk of fire, address a
public safety concern or avoid interference with fire control.</p>
<button (click)="navToMap()" mat-button class="map-button"><img height="20" width="20" class="tertiary-icon"
Expand All @@ -8,9 +8,9 @@
<hr>
<div class="info-container">
<div class="info"><img height="20" width="20" class="icon" src="/assets/images/svg-icons/carbon_calendar.svg"
alt="Calendar" />Issued on {{restrictionData.issuedDate}}</div>
alt="Calendar" />Issued on {{restrictionData?.issuedDate}}</div>
<div class="info"><img height="20" width="20" class="icon" src="/assets/images/svg-icons/location-pin.svg"
alt="Location Pin" />{{restrictionData.fireCentre}}</div>
alt="Location Pin" />{{restrictionData?.fireCentre}}</div>
<div class="info"><img height="20" width="20" class="icon" src="/assets/images/svg-icons/carbon_layers.svg"
alt="Layers" />BC Wildfire Area Restrictions Layer</div>
</div>
Expand All @@ -26,7 +26,7 @@
of Note</div>
<div class="info"><span class="circle-icon {{incident.stageOfControlIcon}}"></span>{{incident.stageOfControlLabel}}</div>
<div class="info"><img height="20" width="20" class="icon" src="/assets/images/svg-icons/location-pin.svg"
alt="Location Pin" />{{restrictionData.fireCentre}}</div>
alt="Location Pin" />{{restrictionData?.fireCentre}}</div>
<div class="info"><img height="20" width="20" class="icon" src="/assets/images/svg-icons/carbon_calendar.svg"
alt="Calendar" />Discovered on {{incident.discoveryDate}}<img height="20" width="20" class="arrow-button"
alt="icon" src="/assets/images/svg-icons/forward-arrow-grey.svg"></div>
Expand Down
2 changes: 1 addition & 1 deletion ...nts/wildfires-list-header/area-restriction-list/area-restriction-list.component.mobile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { AreaRestrictionListComponent } from './area-restriction-list.component'
})
export class AreaRestrictionListComponentMobile extends AreaRestrictionListComponent {
navigateToFullDetails(item: any) {
if (item.protRsSysID) {
if (item.protRsSysID !== undefined && item.protRsSysID !== null) {
this.router.navigate([ResourcesRoutes.FULL_DETAILS], {
queryParams: {
type: 'area-restriction',
Expand Down
Loading